Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspaceRoot -> workspaceFolder #187

Merged
merged 2 commits into from
Nov 25, 2020
Merged

workspaceRoot -> workspaceFolder #187

merged 2 commits into from
Nov 25, 2020

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Nov 25, 2020

According to the docs, ${workspaceRoot} is now deprecated:

imagen

@yajo yajo self-assigned this Nov 25, 2020
@yajo yajo added the automerge Marks the PR to be automatically merged when required checks pass label Nov 25, 2020
@yajo yajo added this to the v2.5.0 milestone Nov 25, 2020
@yajo
Copy link
Contributor Author

yajo commented Nov 25, 2020

Tests should go ✔️ now. I also added a workaround for the heisenbug microsoft/vscode-python#14820.

@yajo
Copy link
Contributor Author

yajo commented Nov 25, 2020

I hope this failure is fixed with #184.

@yajo yajo added the autoupdate A bot will try to keep this PR updated automatically rebasing label Nov 25, 2020
@yajo yajo closed this Nov 25, 2020
@yajo yajo reopened this Nov 25, 2020
@yajo yajo removed the autoupdate A bot will try to keep this PR updated automatically rebasing label Nov 25, 2020
@github-actions github-actions bot merged commit 6315685 into devel Nov 25, 2020
@github-actions github-actions bot deleted the workspacefolder branch November 25, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Marks the PR to be automatically merged when required checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants