Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

OrderBy implementation in list actions #56

Merged
merged 3 commits into from
Oct 6, 2016
Merged

OrderBy implementation in list actions #56

merged 3 commits into from
Oct 6, 2016

Conversation

adrianlop
Copy link
Contributor

closes #55

@codecov-io
Copy link

codecov-io commented Oct 5, 2016 •
edited
Loading

Current coverage is 91.61% (diff: 100%)

Merging #56 into master will increase coverage by 0.20%

@@             master        #56   diff @@
==========================================
  Files            18         18          
  Lines          2364       2422    +58   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2161       2219    +58   
  Misses          149        149          
  Partials         54         54

Powered by Codecov. Last update c53ec2d...4dac1ce

rsoletob
rsoletob suggested changes Oct 6, 2016
View reviewed changes
Copy link
Contributor

@rsoletob rsoletob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, great work

api/testutils_test.go
@@ -100,6 +101,8 @@ func makeTestRepo() *TestRepo {
testRepo.ArgsIn[RemovePolicyMethod] = make([]interface{}, 1)
testRepo.ArgsIn[GetPoliciesFilteredMethod] = make([]interface{}, 1)
testRepo.ArgsIn[GetAttachedGroupsMethod] = make([]interface{}, 2)
testRepo.ArgsIn[GetPoliciesFilteredMethod] = make([]interface{}, 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated, see 102 line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@adrianlop
Copy link
Contributor Author

also renamed test map in TestPostgresRepo_OrderByValidColumns

@adrianlop adrianlop merged commit f4a6da2 into master Oct 6, 2016
@adrianlop adrianlop deleted the 55-OrderBy branch October 6, 2016 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rsoletob rsoletob rsoletob approved these changes

@gerson24 gerson24 gerson24 approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow OrderBy in list actions
4 participants
@adrianlop @codecov-io @gerson24 @rsoletob