Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support symbol keys #151

Merged
merged 3 commits into from
Jun 20, 2019
Merged

Support symbol keys #151

merged 3 commits into from
Jun 20, 2019

Conversation

natesilva
Copy link
Contributor

Fix for #150.

@natesilva
Copy link
Contributor Author

natesilva commented Jun 19, 2019 •
edited
Loading

The test fail was in the readme.md, I don’t think it’s related to these changes.

@natesilva
Limit to enumerable symbols
2f0e45a 
This parallels Object.keys, which only returns enumerable names.
@TehShrike
Copy link
Owner

Oh yeah, that failure is my fault from an earlier change. This change looks good to me.

@TehShrike TehShrike merged commit f5f67eb into TehShrike:master Jun 20, 2019
@TehShrike TehShrike mentioned this pull request Jun 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@natesilva @TehShrike