Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to specify concat array merge strategy #22

Closed
wants to merge 4 commits into from
Closed

Added the ability to specify concat array merge strategy #22

wants to merge 4 commits into from

Conversation

anthonator
Copy link

Merge arrays by pushing src to target.

e.g. [1, 2] + [3] => [1, 2, 3]

@KyleAMathews
Copy link
Collaborator

@anthonator hey! I'd love to make you a collaborator so you can merge this and other PRs and roll a new release! Please signup over at #25 and let's make this happen!

@TehShrike
Copy link
Owner

Very similar to #32.

I think my comment at #32 (comment) applies - I can totally understand why you would want to be able to control the array merging behavior. I'm leaning towards allowing consumers to pass in the strategy as a function instead of a pre-determined option, though. Any thoughts on the subject?

@TehShrike
Copy link
Owner

Please comment on #37, another pull request with a potential solution to this issue.

@TehShrike TehShrike closed this in d34ab12 Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants