Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netif: add TAI_NETWORK_INTERFACE_ATTR_CLIENT_SIGNAL_MAPPING_TYPE #137

Merged

Conversation

toru-mano
Copy link
Contributor

This pull request corresponds to issue #131.

As described in the issue, we need one more setting attribute to uniquely describe and specify a transmission mode, namely, TAI_NETWORK_INTERFACE_ATTR_CLIENT_SIGNAL_MAPPING_TYPE. This pull request adds it.

The client mapping name corresponds to the title of the corresponding specification title. That is, OTU4_LR refers to the client signal mapping method described in ITU-T G.709.2 "OUT4 long-reach interface." FlexO_LR refers to the client signal mapping method described in ITU-T G.709.3 "Flexible OTN long-reach interface." ZR refers to OIF 400ZR and OpenZR+.

@ishidawataru
Copy link
Collaborator

@toru-mano Could you add a reference comment for each enum value like below?

/**
   @reference ITU-T G.709.2 "OUT4 long-reach interface.
 */
TAI_NETWORK_INTERFACE_CLIENT_SIGNAL_MAPPING_TYPE_OTU4_LR,

@toru-mano toru-mano force-pushed the netif-client-mapping branch from 18405e6 to 5d7acb1 Compare August 31, 2021 05:20
@toru-mano
Copy link
Contributor Author

toru-mano commented Aug 31, 2021

@ishidawataru Thank you for checking! I added references, squashed, and pushed.

@ishidawataru ishidawataru merged commit ba4b1ba into Telecominfraproject:master Aug 31, 2021
@toru-mano toru-mano deleted the netif-client-mapping branch September 10, 2021 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants