feat(QAB-164): Update s3 steps to use aws golang sdk v2 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rt PATH=/Users/zc01167/sdk/go1.18.2/bin:$PATH clear
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
- Coverage 62.35% 62.03% -0.33%
==========================================
Files 47 47
Lines 2925 2924 -1
==========================================
- Hits 1824 1814 -10
- Misses 1039 1046 +7
- Partials 62 64 +2
Continue to review full report at Codecov.
|
mariolg
reviewed
Jul 1, 2022
jordipuigbou
requested review from
mariolg,
ricardogarfe,
AntonioCatalanSanchez and
sarmar11
jordipuigbou
changed the title
mariolg
reviewed
Jul 1, 2022
ricardogarfe
approved these changes
Jul 1, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Please provide enough information so that others can review your pull request:
Explain the details for making this change. What existing problem does the pull request solve?
Documentation
Update Readme docs if needed.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Code formatting
Closing issues
Put
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).