fix(MAGNETO-7807): Fixed rabbitmq sonar issues #86

jordipuigbou · 2022-04-05T14:26:55Z

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Documentation

Update Readme docs if needed.

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

codecov-commenter · 2022-04-05T14:35:27Z

Codecov Report

Merging #86 (94aa587) into master (2403aae) will increase coverage by 32.34%.
The diff coverage is 73.77%.

@@             Coverage Diff             @@
##           master      #86       +/-   ##
===========================================
+ Coverage   10.16%   42.50%   +32.34%     
===========================================
  Files          12       27       +15     
  Lines         935     2068     +1133     
===========================================
+ Hits           95      879      +784     
- Misses        827     1134      +307     
- Partials       13       55       +42

Impacted Files	Coverage Δ
launcher.go	`0.00% <0.00%> (ø)`
steps/dns/steps.go	`0.00% <0.00%> (ø)`
steps/http/logger.go	`0.00% <0.00%> (ø)`
steps/rabbit/steps.go	`0.00% <0.00%> (ø)`
steps/rabbit/amqp.go	`11.11% <11.11%> (ø)`
table.go	`38.17% <63.76%> (+38.17%)`	⬆️
steps/dns/session.go	`82.31% <84.21%> (ø)`
steps/jwt/session.go	`89.08% <91.30%> (ø)`
steps/rabbit/session.go	`96.32% <96.15%> (ø)`
steps/dns/logger.go	`62.50% <100.00%> (ø)`
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261eed8...94aa587. Read the comment docs.