Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config sonar issues #92

Merged
merged 2 commits into from
Apr 13, 2022
Merged

fix: config sonar issues #92

merged 2 commits into from
Apr 13, 2022

Conversation

jordipuigbou
Copy link
Contributor

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Documentation

Update Readme docs if needed.

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2022

Codecov Report

Merging #92 (82a987a) into master (ec1622f) will increase coverage by 0.59%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   52.70%   53.29%   +0.59%     
==========================================
  Files          40       40              
  Lines        2605     2608       +3     
==========================================
+ Hits         1373     1390      +17     
+ Misses       1177     1161      -16     
- Partials       55       57       +2     
Impacted Files Coverage Δ
config.go 50.00% <100.00%> (+50.00%) ⬆️
map.go 13.79% <0.00%> (+13.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1622f...82a987a. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ricardogarfe ricardogarfe merged commit b37f18e into master Apr 13, 2022
@ricardogarfe ricardogarfe deleted the fix-config-sonar-issues branch April 13, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants