Use OSLog when available instead of print #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeehut
requested changes
Jan 25, 2024
| @@ -1,4 +1,5 @@ | |||
| import Foundation | |||
| import OSLog | |||
There was a problem hiding this comment.
@easydev991 Don't you need to make sure that this can be imported before importing it? I imagine building on systems without access to OSLog would make the code fail.
| @@ -29,7 +30,16 @@ public struct LogHandler { | |||
|
|
|||
| public static var stdout = { logLevel in | |||
| LogHandler(logLevel: logLevel) { level, message in | |||
| print("[TelemetryDeck: \(level.description)] \(message)") | |||
| if #available(macOS 11.0, *) { | |||
There was a problem hiding this comment.
The availability check here only checks for macOS, but this lib supports other platforms as well. Those should be checked, too. Consider also Linux/Windows platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue #131 and decided to contribute.