Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持在Gradle4.6+AGP3.0.0环境运行 #82

Merged
merged 1 commit into from
Aug 6, 2019
Merged

支持在Gradle4.6+AGP3.0.0环境运行 #82

merged 1 commit into from
Aug 6, 2019

Conversation

PhantomQi
Copy link
Contributor

No description provided.

@tencent-adm
Copy link
Member

tencent-adm commented Aug 5, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shifujun shifujun changed the base branch from master to dev August 5, 2019 07:38
@shifujun
Copy link
Collaborator

shifujun commented Aug 5, 2019

我先写一个测试用例测一下原本不兼容的场景是怎样的，再理解下这个改动为什么要反射getExtension方法。

要解决的问题场景是哪一个呢？

  1. Gradle4.6和AGP3.0.0同时使用？
  2. Gradle4.6或AGP3.0.0其中一个使用？

我从代码上看不出跟两者哪个相关，或者是同时相关的。

@shifujun
Copy link
Collaborator

shifujun commented Aug 6, 2019

我通过将projects/sample/maven/plugin-project的Gradle版本改成4.6验证了原本就是支持4.6的。所以这个PR应该跟Gradle 4.6没有关系吧？

@PhantomQi
Copy link
Contributor Author

我通过将projects/sample/maven/plugin-project的Gradle版本改成4.6验证了原本就是支持4.6的。所以这个PR应该跟Gradle 4.6没有关系吧？

本commit是解决Gradle4.6和AGP3.0.0同时使用时遇到的问题，getExtension方法在agp版本之间可见度发生了变化，groovy可以无视可见度的限制，但kotlin会受到可见度的限制，只有通过反射来突破

@shifujun shifujun merged commit a491b83 into Tencent:dev Aug 6, 2019
This was referenced Aug 6, 2019
Merged
Closed
@fortune1992 fortune1992 mentioned this pull request Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PhantomQi @tencent-adm @shifujun