VSX toolchains: check for SSE2 support #4845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves compatibility with Clang 11. Also rename NCNN_SSE* options to NCNN_VSX_SSE* to avoid conflict between x86 and POWER (went unnoticed before because x86 doesn't have an option for toggling SSE 4.1).
Codecov Report
@@ Coverage Diff @@
## master #4845 +/- ##
==========================================
- Coverage 92.94% 92.43% -0.51%
==========================================
Files 309 309
Lines 85822 85765 -57
==========================================
- Hits 79769 79281 -488
- Misses 6053 6484 +431 |
|
Thanks for your contribution ! |
JeremyRand
pushed a commit
to JeremyRand/ncnn
that referenced
this pull request
Nov 23, 2023
Clang prior to 13 no longer fails to build ncnn since Tencent#4845. Clang 18 fixes SSE4.1 translation, which yields a major speedup.
nihui
pushed a commit
that referenced
this pull request
Nov 27, 2023
Clang prior to 13 no longer fails to build ncnn since #4845. Clang 18 fixes SSE4.1 translation, which yields a major speedup. Co-authored-by: Jeremy Rand <jeremyrand@danwin1210.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves compatibility with Clang 11.
Also rename NCNN_SSE* options to NCNN_VSX_SSE* to avoid conflict between x86 and POWER (went unnoticed before because x86 doesn't have an option for toggling SSE 4.1).