Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c_api: expose Mat border processing api #4855

Merged
merged 4 commits into from
Jul 15, 2023
Merged

c_api: expose Mat border processing api #4855

merged 4 commits into from
Jul 15, 2023

Conversation

Mek101
Copy link
Contributor

@Mek101 Mek101 commented Jul 12, 2023

Adds ncnn_copy_make_border, ncnn_copy_make_border_3d, ncnn_copy_cut_border and ncnn_copy_cut_border_3d to the C api

@tencent-adm
Copy link
Member

tencent-adm commented Jul 12, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #4855 (c1e4318) into master (e8645e9) will increase coverage by 0.36%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #4855      +/-   ##
==========================================
+ Coverage   94.53%   94.89%   +0.36%     
==========================================
  Files         779      779              
  Lines      221835   223186    +1351     
==========================================
+ Hits       209706   211795    +2089     
+ Misses      12129    11391     -738
Impacted Files Coverage Δ
src/c_api.cpp 40.58% <0.00%> (-0.98%) ⬇️

... and 41 files with indirect coverage changes

@Mek101
Copy link
Contributor Author

Mek101 commented Jul 12, 2023

Can anyone approve the CI run please?

@nihui
Copy link
Member

nihui commented Jul 13, 2023

enable github action in your forked repo to let code-format work properly

@Mek101
Copy link
Contributor Author

Mek101 commented Jul 13, 2023

Set as r/w

@Mek101
Copy link
Contributor Author

Mek101 commented Jul 14, 2023

Can anyone approve the CI run please?

@Mek101
Copy link
Contributor Author

Mek101 commented Jul 15, 2023

Found the issue

@nihui nihui merged commit a9a7be0 into Tencent:master Jul 15, 2023
@nihui
Copy link
Member

nihui commented Jul 15, 2023

Thanks for your contribution !

@Porkepix Porkepix mentioned this pull request Aug 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihui nihui nihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mek101 @tencent-adm @codecov-commenter @nihui