Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect output for A or B with dim=1 in GEMM #4883

Closed
wants to merge 3 commits into from
Closed

Fix Incorrect output for A or B with dim=1 in GEMM #4883

wants to merge 3 commits into from

Conversation

w8501
Copy link
Contributor

@w8501 w8501 commented Jul 28, 2023

Fixed a bug in the GEMM layer where incorrect shapes of M, N, and K occurred when matrix A or matrix B had dim=1, leading to incorrect output results.

@tencent-adm
Copy link
Member

tencent-adm commented Jul 28, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #4883 (23a5f11) into master (c45c01c) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4883      +/-   ##
==========================================
+ Coverage   89.81%   89.89%   +0.08%     
==========================================
  Files         306      257      -49     
  Lines       86875    65778   -21097     
==========================================
- Hits        78024    59134   -18890     
+ Misses       8851     6644    -2207     
Files Changed Coverage Δ
src/layer/x86/mish_x86.cpp 100.00% <ø> (ø)
src/layer/x86/gemm_x86.cpp 98.73% <100.00%> (ø)

... and 62 files with indirect coverage changes

@w8501 w8501 closed this Jul 28, 2023
@w8501 w8501 reopened this Jul 28, 2023
@w8501 w8501 closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants