Myshrimp #4941

Myshrimp · 2023-08-14T06:29:43Z

No description provided.

tencent-adm · 2023-08-14T06:29:59Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Myshrimp
❌ Liu Jiawei

Liu Jiawei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

zchrissirhcz · 2023-08-16T05:05:40Z

src/simplemath.cpp

+#ifdef NCNN_SIMPLEMATH
+#include <stdlib.h>
+#include<stdio.h>
+float absolute(float x)//����ֵ


The encoding can be improved. UTF-8 encoding recommended. Spaces around // prefered.

i.e.

float absolute(float x) // your_comment

zchrissirhcz · 2023-08-16T05:05:52Z

src/simplemath.cpp

+	return x;
+}
+
+float Factorial(int x)//�׳�


zchrissirhcz · 2023-08-16T05:05:59Z

src/simplemath.cpp

+}
+
+
+float nth(float x, int n)//n�η�


zchrissirhcz · 2023-08-16T05:06:06Z

src/simplemath.cpp

+		return (1 / x) * nth(x, n + 1);
+	}
+}
+float Bernoulli(int x)//��Ŭ����


zchrissirhcz · 2023-08-16T05:06:12Z

src/simplemath.cpp

+			return B;
+		}
+}
+float tan(float x)//tan(x)  ���ȱ���0.000001 �����ٶ�̫��


zchrissirhcz · 2023-08-16T05:06:21Z

src/simplemath.cpp

+		printf("\tNaN\n");
+		return 0;
+	}
+	while (absolute(e) > accuracy && i <= 24)//���Ǽ����ٶȣ�����Bernoulli()


zchrissirhcz · 2023-08-16T05:06:49Z

src/simplemath.h

+#ifndef TAN_H
+#define TAN_H
+#include<stdio.h>
+#define pai 3.14159265


Consider not using Chinese Pinyin when naming a variable.

zchrissirhcz · 2023-08-16T05:07:39Z

src/platform.h.in

@@ -15,6 +15,7 @@
 #ifndef NCNN_PLATFORM_H
 #define NCNN_PLATFORM_H

+#cmakedefine01 NCNN_SIMPLEMATH


Consider moving NCNN_SIMPLEPATH to the bottom, just like the order when src/CMakeLists.txt.

nihui · 2023-10-20T08:04:22Z

pr closed as a much more superior simplemath implementation covered in #4905
thanks anyway !

Myshrimp

25b3f3e