-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add F_pairwise_distance to pnnx and ncnn #4942
Conversation
hi, please enable github action in your forked repo, to let code-format job work properly |
please fix ci error
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall it looks good besides some space style issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't a ncnn layer called PairwiseDistance.
Either implement the layer or drop the ncnn conversion and leave pnnx conversion only.
If you plan to implement the ncnn layer later, add the ncnn conversion at that time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this source as no such ncnn layer exists
Thanks for your contribution ! |
had added to pnnx