Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add F_pairwise_distance to pnnx and ncnn #4942

Merged
merged 19 commits into from
Sep 22, 2023
Merged

add F_pairwise_distance to pnnx and ncnn #4942

merged 19 commits into from
Sep 22, 2023

Conversation

Marsyule
Copy link
Contributor

@Marsyule Marsyule commented Aug 14, 2023

had added to pnnx

@tencent-adm
Copy link
Member

tencent-adm commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@nihui
Copy link
Member

nihui commented Aug 24, 2023

hi, please enable github action in your forked repo, to let code-format job work properly

@nihui
Copy link
Member

nihui commented Sep 4, 2023

please fix ci error

  36/506 Test  #50: test_F_pairwise_distance ......................***Failed    0.06 sec
  File "/data/devops/workspace/tools/pnnx/tests/test_F_pairwise_distance.py", line 52
    return torch.equal(a0,b0) and torch.equal(a1,b1) and torch.equal(a2,b2) and torch.equal(a3,b3)
IndentationError: unexpected indent
CMake Error at /data/devops/workspace/tools/pnnx/tests/run_test.cmake:5 (message):
  Test failed with return value '1'

Copy link
Member

@nihui nihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall it looks good besides some space style issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't a ncnn layer called PairwiseDistance.
Either implement the layer or drop the ncnn conversion and leave pnnx conversion only.

If you plan to implement the ncnn layer later, add the ncnn conversion at that time.

tools/pnnx/src/CMakeLists.txt Outdated Show resolved Hide resolved
tools/pnnx/src/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this source as no such ncnn layer exists

@nihui nihui merged commit 69d6051 into Tencent:master Sep 22, 2023
6 checks passed
@nihui
Copy link
Member

nihui commented Sep 22, 2023

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants