Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix softmax arm fp16s sum error, fix #5340 #5393

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

nihui
Copy link
Member

@nihui nihui commented Mar 28, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (84256b1) to head (436ebaf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5393      +/-   ##
==========================================
- Coverage   94.63%   94.48%   -0.16%     
==========================================
  Files         778      778              
  Lines      243359   243358       -1     
==========================================
- Hits       230302   229925     -377     
- Misses      13057    13433     +376     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihui nihui merged commit 167501f into Tencent:master Mar 30, 2024
42 checks passed
@glenn-jocher
Copy link

@nihui would it be possible to publish new NCNN and/or PNNX versions with this fix? This may help improve Ultralytics YOLO export validation accuracies with NCNN which are trailing other formats:

https://github.com/ultralytics/ultralytics/actions/runs/8584738579/job/23525336246

Screenshot 2024-04-07 at 23 39 37

@nihui
Copy link
Member Author

nihui commented Apr 8, 2024

@nihui would it be possible to publish new NCNN and/or PNNX versions with this fix? This may help improve Ultralytics YOLO export validation accuracies with NCNN which are trailing other formats:

https://github.com/ultralytics/ultralytics/actions/runs/8584738579/job/23525336246
Screenshot 2024-04-07 at 23 39 37

New versions of ncnn and pnnx will be released this week
Currently trying to fix more bugs to ensure stability and compatibility, across gpu risc-v mips etc

senli123 pushed a commit to senli123/ncnn that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants