platform: Add HarmonyOS HiLog support #5562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihui
reviewed
Jul 8, 2024
Comment on lines
+298
to
+305
| #ifndef LOG_DOMAIN | ||
| #define LOG_DOMAIN 0x6E68 | ||
| #endif | ||
| #ifndef LOG_TAG | ||
| #define LOG_TAG "ncnn" | ||
| #endif | ||
| #include <hilog/log.h> | ||
| #define NCNN_LOGE(...) OH_LOG_ERROR(LOG_APP, ##__VA_ARGS__) |
There was a problem hiding this comment.
int OH_LOG_Print(LOG_APP, LOG_WARN, LOG_DOMAIN, "ncnn", ##__VA_ARGS__)
domain could be hardcoded as any code you like here
There was a problem hiding this comment.
这样不行，如果外面调用了，比如下面这种写法
NCNN_LOGE("%d", 1)，转成OH_LOG_ERROR(LOG_APP, "%d", 1)，这个1是不会输出出来的，按鸿蒙的文档中要写成"%{public}d"这样才能输出出来
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.