GenericValue: add optional support for std::string #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By restructuring the call forwarding of the various operator== and operator!= overloads, new overloads can be added by simply adding an additional member operator==. Additionally, the "Ch*" overloads are dropped in favour of an SFINAE version that removes the pointer variants from matching the templated operator== (see also operator=).
Some users may want to use RapidJSON with std::string objects. This commits adds an (opt-in) feature to include some basic support. The implementation uses std::basic_string<Ch> as generic string type. Support currently covers: * construction * comparison No special APIs for AddMember or PushBack have been added, as std::string most probably requires copying (or an explicit StringRef() call).
pah
referenced
this pull request
in Urban82/rapidjsonxml
Aug 20, 2014
miloyip
added a commit
that referenced
this pull request
Aug 20, 2014
GenericValue: add optional support for std::string
This was referenced May 13, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users want to use RapidJSON with
std::stringobjects. This pull-request adds an (opt-in) feature to include some basic support. The implementation usesstd::basic_string<Ch>as generic string type.GenericValue's string support currently covers:SetStringNo special APIs for
AddMemberorPushBackhave been added, asstd::stringmost probably requires copying (or an explicit StringRef() call). Using theGenericValueconstructor should be sufficient:std::string str; d.AddMember("string", Value(str, d.GetAllocator()).Move(), d.GetAllocator());The functionality needs to be enabled by defining
RAPIDJSON_HAS_STDSTRING. The Travis CI config has been updated to add this define by default to include the tests.Last, but not least, the comparison operators have been refactored to simplify the addition of new overloads (see 702b45b). With the new forwarding structure, only a single function needs to be added to extend the comparison support.