Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(image): support aria #1136

Merged
merged 4 commits into from
Dec 5, 2022
Merged

Conversation

zhangpaopao0609
Copy link
Contributor

@zhangpaopao0609 zhangpaopao0609 commented Nov 29, 2022

🤔 这个 PR 的性质是?

  • 新特性提交

🔗 相关 Issue

fix #1030

💡 需求背景和解决方案

  1. image 增加 aria-hiddenaria-label (已用示例测试过,在组件上添加 aria-label 即可)
  2. icon 增加 aria-rolearia-label
  3. 其中”加载中“需要 t-loading 组件提供

ios 录屏

6b56499640b4aa4914fd9748e02ecef1.mov

📝 更新日志

  • feat(Image): 支持无障碍访问

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@syxysszyw
Copy link
Collaborator

@zhangpaopao0609 后续提交的录屏尽量录一个从头到尾的(可以让读屏光标先定位在最顶部的标题处,然后双指向下轻扫,就能实现自动从光标位置开始自动朗读)

src/image/_example/base/index.wxml Show resolved Hide resolved
src/image/image.wxml Show resolved Hide resolved
@syxysszyw syxysszyw mentioned this pull request Nov 30, 2022
16 tasks
@syxysszyw
Copy link
Collaborator

一个小细节,这里光标不对,把2个内容圈起来了
image

@LeeJim LeeJim added the a11y 无障碍访问 label Dec 2, 2022
@syxysszyw
Copy link
Collaborator

Image这个组件是不是也能支持一下aria-role,比较容易想象类似的这个使用场景(图片按钮、图标链接)

@LeeJim LeeJim merged commit c1f61eb into Tencent:develop Dec 5, 2022
@github-actions github-actions bot mentioned this pull request Dec 5, 2022
LeeJim added a commit that referenced this pull request Dec 7, 2022
* fix(calendar): remove useless classname

* feat(button): using new style (#993)

* feat(fab): using new style (#995)

* feat(fab): using new style

* test(fab): update

* feat(tag): using new style (#997)

* feat(tag): using new style

* feat(tag): check-tag support variant and extra-large size

* fix(NoticeBar): support dynamic update of some properties (#999)

* test: update demo test

* build: remove useless using (#1000)

* fix(tabbar): resolve width when fixed (#1001)

* chore: publish v0.25.0-beta.0

* feat(cell): using new style

* feat(cell): using new style (#1003)

* feat(cell): using new style

* test(cell): update snapshot

* test(cell): update snapshot

* test: using load function

* Feat/new grid (#1006)

* feat(cell): using new style

* fix(grid): update demo

* feat(grid): finish new version

* test(grid): update snapshot

* fix(grid): remove virtual-host option

* fix(textarea): using correct default value of confirm-type (#1007)

* fix(textarea): using correct default value of confirm-type

* test(textarea): update snapshot

* Feat/new navbar (#1010)

* fix(textarea): using correct default value of confirm-type

* test(textarea): update snapshot

* fix(navbar): update demo

* feat(navbar): finish new style

* test(navbar): update snapshot

* test(navbar): update snapshot

* fix(cascader): resolve async options (#1011)

* Fix/grid/layout (#1012)

* fix(grid): resolve layout problem

* fix(action-sheet): resolve layout

* test(grid): update snapshot

* chore: publish v0.26.0 (#1013)

* chore: publish v0.26.0

* chore: changelog's changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(divider): using new style (#1035)

* feat(divider): using new style

* test(divider): update snapshot

* feat(upload): using new style (#1034)

* feat(upload): using new style

* fix(upload): update demo & snapshot

* Feat/new collapse (#1039)

* feat(collapse): add theme property

* test(collapse): update snapshots

* feat(image): using new style (#1038)

* feat(image): using new style

* fix(image): remove useless demo & update snapshots

* feat(toast): using new style (#1073)

* feat(toast): using new style

* test(image-viewer): update snapshot

* style(Empty): using new style (#1041)

* feat(Result): support iconProps attr (#1040)

* feat(Result): support iconProps attr

* style(Result): use css token

* style(Skeleton): using new style (#1037)

* style(Skeleton): using new style

* style(Skeleton): use css token

* style(ImageViewer): using new style (#1074)

* style(Footer): use css token (#1042)

* style(footer): use css token

* chore: use t-image component

* feat(switch): using new style (#1080)

* feat(switch): using new style

* test(switch): upate snapshots

* fix(switch): update style

* style(Avatar): using css token (#1076)

* fix(navbar): resolve status bar height correctly (#1083)

* fix(navbar): resolve status bar height correctly

* test(navbar): update snapshot

* feat(badge): using new style (#1004)

* feat(badge): using new style

* test(badge): update snapshot

* feat(badge): using new style

* test(badge): update snapshot

* test(badge): update snapshot

* docs: update docs for some components (#1086)

* fix(search): render slot by default (#1087)

* chore: publish v0.27.0 (#1088)

* chore: publish v0.27.0

* chore: changelog's changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix: update category and demo

* test(side-bar): update snapshots

* test(navbar): update snapshot

* fix(tabs): resolve render blink (#1093)

* fix(tabs): resolve render blink

* test(tabs): update snapshot

* fix(result): 修复装饰性图标获取焦点的问题 (#1082)

* Feat/new radio (#1098)

* feat(radio): update demo

* feat(radio): using new style

* test(radio): update snapshot

* docs(radio): update

* fix(radio): using union token

* test(radio): update snapshot

* Feat/new checkbox (#1100)

* feat(checkbox): using new style

* docs(checkbox): update

* docs(checkbox): update

* Feat/new search (#1103)

* feat(search): using new style

* test(search): update snapshot

* fix(Tabs): fix tabs left layout (#1099)

* fix(toast): support text wrap (#1107)

* Fix/tabs/animation (#1106)

* fix(tabs): resolve animation

* test(tabs): update snapshot

* feat(Textarea): enrich attributes (#1097)

* feat(Textarea): enrich attributes

* docs(Textarea): update docs

* fix(tabs): calculate offset correctly (#1111)

* feat: aria-footer (#1104)

* feat: aria-footer

* fix: aira-footer

Co-authored-by: zhanghaixu1 <zhanghaixu1@tal.com>

* chore: update gitignore

* fix(navbar): resolve navbar color (#1116)

* style(CountDown): using css token (#1085)

* style(CountDown): using css token

* feat(Textarea): support hightlight theme

* feat(input): support nickname type (#1115)

* fix(calendar): enable controlled usage (#1119)

* fix(calendar): enable controlled usage

* test(calendar): update snapshots

* test(calendar): update snapshots

* fix(calendar): enable without confirm button (#1120)

* feat(cell): support css variables (#1117)

* [Checkbox] 无障碍支持 (#1105)

* feat:aria-checkbox

* feat: feat:checked-mixed

* fix: aria-checkbox

Co-authored-by: leejimqiu <leejimqiu@gmail.com>

* fix(navbar): update docs and demo (#1124)

* fix(navbar): update docs and demo

* test(navbar): update snapshot

* fix(popup): remove catch touch-move (#1125)

* fix(popup): remove catch touch-move

* test(popup): update snapshot

* feat(Grid): support iconProps: (#1123)

* fix(loading): resolve size problem (#1128)

* feat: support aria property for all component (#1127)

* feat: support aria property for all component

* test(icon): update snapshot

* test(icon): update snapshot

* fix(dropdown-menu): resolve checkbox style (#1129)

* fix(cascader): resolve radio style (#1130)

* feat(Input): enrich attributes (#1109)

* feat(Input): enrich attributes

* fix: fix cr

Co-authored-by: leejimqiu <leejimqiu@gmail.com>

* chore: publish v0.28.0 (#1131)

* chore: publish v0.28.0

* chore: changelog's changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* fix(checkbox): enable to use image icon (#1135)

* chore: publish v0.28.0-beta.0

* build: update tag push

* chore: publish v0.28.0-beta.1

* Aria search (#1132)

* feat: aria-search

* feat: aria-search

* test: aria-search

Co-authored-by: chongliang <chongliang@tencent.com>

* feat(action-sheet): using new style (#1142)

* feat(action-sheet): using new style

* test(action-sheet): update snapshot

* docs: update contributing

* feat(drawer): using new style (#1147)

* feat(drawer): using new style

* feat(drawer): update style and demo

* Feat/new loading (#1152)

* feat(loading): using new style

* test(loading): update snapshot

* fix(loading): update style

* test(loading): update snapshot

* feat(message): support aria (#1150)

* feat(stepper): stepper aria (#1144)

* feat(stepper): support aria

* test(stepper): update snap

* feat(stepper): add step info

* test(stepper): update snap

* fix(radio): 修复朗读问题. (#1026) (#1139)

* fix(radio): 修复朗读问题. (#1026)

* fix(radio): 修复禁用问题, 区域问题问题. (#1026)

* fix(radio): 修复按钮组几分之几问题. (#1026)

* fix(avatar): 无障碍朗读支持

* fix(avatar): 无障碍朗读支持. (#1028)

* fix(avatar): 支持自定义无障碍标签. (#1028)

* fix(avatar): 头像aria-label 兜底问题. (#1028)

* fix(avatar): 头像超出问题, 文案问题, 快照问题 (#1028)

* test: snap update

* fix(cascader): remove options without errors (#1163)

* build: support auto preview (#1168)

* feat(progress): support progress aria (#1156)

* feat(progress): support progress aria

fix #1049

* fix(progress): add props

add props

* feat(image): support aria (#1136)

* feat(image): support aria

* test(image): update snap

* feat(image): example add aria-label

* test(image): update snap

* docs(tabs): update document

* chore: publish v0.29.0 (#1171)

* chore: publish v0.29.0

* chore: changelog's changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* feat(navbar): aria-navbar (#1140)

* style(Message): using css token (#1153)

* style(Message): using css token

* fix: fix cr

* fix(calendar): enable reactive max-date\min-date\first-day-of-week (#1172)

* fix: fix:aria-checkbox-demo (#1176)

* build: enable to preview on pr

* build: download artifact correctly

* build: get preview qrcode currectly

* build: update ci

* build: update preview ci

* build: get correct code

* build: checkout repo correctly

* fix: resolve backtop demo

Co-authored-by: Y <anly_yaw@163.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: omnis <39907007+aomnisz@users.noreply.github.com>
Co-authored-by: Isabella327 <49264532+Isabella327@users.noreply.github.com>
Co-authored-by: zhanghaixu1 <zhanghaixu1@tal.com>
Co-authored-by: chongliang <chongliang@tencent.com>
Co-authored-by: paopao <zhangpaopao0609@gmail.com>
Co-authored-by: byqbai <1213567900@qq.com>
Co-authored-by: byqbai <byq1213@qq.com>
Co-authored-by: 龙风 <455947455@qq.com>
Co-authored-by: Lindddt <44339196+Lindddt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 无障碍访问
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Image] 无障碍支持
3 participants