-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dropdown): dropdown-menu无障碍支持 #1285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syxysszyw
reviewed
Dec 27, 2022
8539b2b513b60d13bf61de912a2cc603.mp4新版本视频 |
Lindddt
commented
Dec 28, 2022
syxysszyw
reviewed
Dec 28, 2022
预览1 |
预览1 |
syxysszyw
reviewed
Dec 30, 2022
预览2 |
syxysszyw
approved these changes
Dec 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LeeJim
approved these changes
Dec 31, 2022
Merged
LeeJim
added a commit
that referenced
this pull request
Jan 3, 2023
* chore: remove optional chain on demo (#1298) * chore: update website readme (#1301) * docs: add version information (#1300) * build: add npm cache * build: preview ci updated * feat(indexes): 读屏优化 (#1237) * feat(indexes): 增加读屏 * feat(indexes): test * fix(progress): 优化朗读次数 (#1283) * fix(progress): 优化朗读次数 * fix: 新增异常朗读 * feat(Badge): support Badge aria (#1196) * feat(badge): badge support aria fix #1019 * feat(badge): fix code * test(badge): update snap * fix(badge): fix code * fix: fix code * fix: fix code * fix: fix code * fix: fix: fix code * fix: update snap * fix: fix code * style: remove useless css (#1314) * feat(example): add a11y support (#1313) * feat(example): add a11y support * feat(example): add a11y support * feat: icon attribute supports object type (#1295) * feat: icon attribute supports object type * test: update snapshoot * fix(swiper): update style (#1327) * fix(cascader): update style (#1326) * style(Result): update style (#1325) * refactor(badge): using real unique id (#1321) * refactor(badge): using real unique id * refactor: finish unique logic * refactor: remove userid * fix(PullDownRefresh): update demo (#1333) * style(Progress): update style (#1328) * docs: 文档 button 属性使用错误 (#1347) * fix(tabs): update style (#1339) * fix(tabs): update style * fix(tabs): update a11y * fix(steps): update style (#1351) * fix(steps): update style * test(steps): update snapshot * fix(rate): update style (#1350) * fix(Stepper): update style (#1356) * fix(Stepper): update style * test: update snapshots * fix(tag): resolve icon and control (#1358) * fix(tag): resolve icon and control * test(tag): update snapshot * fix(drawer): update style (#1359) * feat(treeselect): 读屏优化 (#1355) * feat(treeselect): 读屏优化 * feat(sidebaritem): 读屏优化 * feat(sidebaritem): 读屏优化 * feat(sidebaritem): 读屏优化 * fix: update cos url (#1364) * Fix/upload/style (#1365) * fix(upload): update style * test(upload): update snapshot * fix(dialog): replace url (#1362) * fix(dropdown-menu): update reset logic and style (#1363) * fix(action-sheet): 修复旁白读取问题. (#1064) (#1235) * fix(action-sheet): 修复旁白读取问题. (#1064) * fix(action-sheet): 优化弹出框聚焦, 多余无效role属性 * fix(action-sheet): 修复旁白读取问题. (#1064) * fix(action-sheet): 优化弹出框聚焦, 多余无效role属性 * fix(action-sheet): 列表选项语义化. (#1064) * fix(action-sheet): onCancel 恢复变更, 按钮语义恢复. (#1064) * fix(action-sheet): 去掉多余的focus属性. (#1064) * fix(action-sheet): 兼容动态role. (#1064) * fix(action-sheet): android tabindex. (#1064) * fix(switch): 开关无障碍旁白补充 (#1279) * fix(switch): 修复朗读不可用问题. (#1018) * fix(switch): 修复朗读勾选问题. (#1018) * fix(switch): icon读取问题. (#1018) * fix(switch): update snapshot. (#1018) * fix(switch): update role. (#1018) * fix(switch): update snapshot. (#1018) * fix(switch): delete disabled. (#1018) * feat(cell): 增加无障碍支持 (#1212) Co-authored-by: lsdyi <yangjinzhehao123@outlook.com> * feat(dropdown): dropdown-menu无障碍支持 (#1285) * feat(dropdown): dropdown-menu无障碍支持 * feat(dropdown): 代码优化 * fix(code): 回退代码 * fix(dropdown-menu): 删除aria-hidden属性 * fix(slider): support a11y * chore(switch): update demo (#1368) * fix(tab-bar): update style (#1369) * fix(checkbox): update style (#1371) * fix(search): update demo (#1370) * fix(navbar): update style (#1372) * fix(navbar): update style * test(navbar): update snapshot * fix(navbar): optimize * fix(navbar): make the custom-style property reactive (#1374) * fix(navbar): make the custom-style property reactive * test(navbar): update snapshot * chore: publish v0.33.0 (#1378) * chore: publish v0.33.0 * chore: changelog's changes Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Y <anly_yaw@163.com> Co-authored-by: Lzzzz <lz_n10828@163.com> Co-authored-by: 龙风 <455947455@qq.com> Co-authored-by: Jason <jason.daurus@gmail.com> Co-authored-by: 大补 <38815121+AuYuHui@users.noreply.github.com> Co-authored-by: byqbai <byq1213@qq.com> Co-authored-by: lsdyi <52379902+lsdyi@users.noreply.github.com> Co-authored-by: lsdyi <yangjinzhehao123@outlook.com> Co-authored-by: Lindddt <44339196+Lindddt@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #1047
💡 需求背景和解决方案
给dropdown-menu增加了对应的label,将item的文字以及icon合并,一个item激活时,其他item暂时隐藏。
dropdown-item的选项增加tabindex以实现展开时快速聚焦。
📝 更新日志
feat(DropdownMenu): 支持无障碍访问
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单
视频
56ab9c3c4e4db8e951917c85900f841c.mp4
6bf3a7da1f2437b7315d643b7cb3cca4.mp4