Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdown): dropdown-menu无障碍支持 #1285

Merged
merged 4 commits into from
Dec 31, 2022
Merged

Conversation

Lindddt
Copy link
Contributor

@Lindddt Lindddt commented Dec 27, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #1047

💡 需求背景和解决方案

给dropdown-menu增加了对应的label,将item的文字以及icon合并,一个item激活时,其他item暂时隐藏。
dropdown-item的选项增加tabindex以实现展开时快速聚焦。

📝 更新日志

  • feat(DropdownMenu): 支持无障碍访问

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

视频

56ab9c3c4e4db8e951917c85900f841c.mp4
6bf3a7da1f2437b7315d643b7cb3cca4.mp4

@LeeJim LeeJim added the a11y 无障碍访问 label Dec 27, 2022
src/dropdown-menu/dropdown-menu.wxml Outdated Show resolved Hide resolved
src/dropdown-menu/dropdown-menu.wxml Outdated Show resolved Hide resolved
src/dropdown-menu/dropdown-item.wxml Outdated Show resolved Hide resolved
src/checkbox/checkbox.wxml Show resolved Hide resolved
@Lindddt
Copy link
Contributor Author

Lindddt commented Dec 28, 2022

8539b2b513b60d13bf61de912a2cc603.mp4

新版本视频

src/checkbox/checkbox.wxml Show resolved Hide resolved
src/dropdown-menu/dropdown-menu.ts Outdated Show resolved Hide resolved
src/dropdown-menu/dropdown-menu.wxml Outdated Show resolved Hide resolved
@syxysszyw
Copy link
Collaborator

预览1

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

qrcode

@syxysszyw
Copy link
Collaborator

预览1

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

qrcode

@syxysszyw
Copy link
Collaborator

syxysszyw commented Dec 30, 2022

@syxysszyw
Copy link
Collaborator

预览2

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

qrcode

Copy link
Collaborator

@syxysszyw syxysszyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim LeeJim merged commit a42a236 into Tencent:develop Dec 31, 2022
@github-actions github-actions bot mentioned this pull request Jan 2, 2023
LeeJim added a commit that referenced this pull request Jan 3, 2023
* chore: remove optional chain on demo (#1298)

* chore: update website readme (#1301)

* docs: add version information (#1300)

* build: add npm cache

* build: preview ci updated

* feat(indexes): 读屏优化 (#1237)

* feat(indexes): 增加读屏

* feat(indexes): test

* fix(progress): 优化朗读次数 (#1283)

* fix(progress): 优化朗读次数

* fix: 新增异常朗读

* feat(Badge): support Badge aria  (#1196)

* feat(badge): badge support aria

fix #1019

* feat(badge): fix code

* test(badge): update snap

* fix(badge): fix code

* fix: fix code

* fix: fix code

* fix: fix code

* fix: fix: fix code

* fix: update snap

* fix: fix code

* style: remove useless css (#1314)

* feat(example): add a11y support (#1313)

* feat(example): add a11y support

* feat(example): add a11y support

* feat: icon attribute supports object type (#1295)

* feat: icon attribute supports object type

* test: update snapshoot

* fix(swiper): update style (#1327)

* fix(cascader): update style (#1326)

* style(Result): update style (#1325)

* refactor(badge): using real unique id (#1321)

* refactor(badge): using real unique id

* refactor: finish unique logic

* refactor: remove userid

* fix(PullDownRefresh): update demo (#1333)

* style(Progress): update style (#1328)

* docs: 文档 button 属性使用错误 (#1347)

* fix(tabs): update style (#1339)

* fix(tabs): update style

* fix(tabs): update a11y

* fix(steps): update style (#1351)

* fix(steps): update style

* test(steps): update snapshot

* fix(rate): update style (#1350)

* fix(Stepper): update style (#1356)

* fix(Stepper): update style

* test: update snapshots

* fix(tag): resolve icon and control (#1358)

* fix(tag): resolve icon and control

* test(tag): update snapshot

* fix(drawer): update style (#1359)

* feat(treeselect): 读屏优化 (#1355)

* feat(treeselect): 读屏优化

* feat(sidebaritem): 读屏优化

* feat(sidebaritem): 读屏优化

* feat(sidebaritem): 读屏优化

* fix: update cos url (#1364)

* Fix/upload/style (#1365)

* fix(upload): update style

* test(upload): update snapshot

* fix(dialog): replace url (#1362)

* fix(dropdown-menu): update reset logic and style (#1363)

* fix(action-sheet): 修复旁白读取问题. (#1064) (#1235)

* fix(action-sheet): 修复旁白读取问题. (#1064)

* fix(action-sheet): 优化弹出框聚焦, 多余无效role属性

* fix(action-sheet): 修复旁白读取问题. (#1064)

* fix(action-sheet): 优化弹出框聚焦, 多余无效role属性

* fix(action-sheet): 列表选项语义化. (#1064)

* fix(action-sheet): onCancel 恢复变更, 按钮语义恢复. (#1064)

* fix(action-sheet): 去掉多余的focus属性. (#1064)

* fix(action-sheet): 兼容动态role. (#1064)

* fix(action-sheet): android tabindex. (#1064)

* fix(switch): 开关无障碍旁白补充 (#1279)

* fix(switch): 修复朗读不可用问题. (#1018)

* fix(switch): 修复朗读勾选问题. (#1018)

* fix(switch): icon读取问题. (#1018)

* fix(switch): update snapshot. (#1018)

* fix(switch): update role. (#1018)

* fix(switch): update snapshot. (#1018)

* fix(switch): delete disabled. (#1018)

* feat(cell): 增加无障碍支持 (#1212)

Co-authored-by: lsdyi <yangjinzhehao123@outlook.com>

* feat(dropdown): dropdown-menu无障碍支持 (#1285)

* feat(dropdown): dropdown-menu无障碍支持

* feat(dropdown): 代码优化

* fix(code): 回退代码

* fix(dropdown-menu): 删除aria-hidden属性

* fix(slider): support a11y

* chore(switch): update demo (#1368)

* fix(tab-bar): update style (#1369)

* fix(checkbox): update style (#1371)

* fix(search): update demo (#1370)

* fix(navbar): update style (#1372)

* fix(navbar): update style

* test(navbar): update snapshot

* fix(navbar): optimize

* fix(navbar): make the custom-style property reactive (#1374)

* fix(navbar): make the custom-style property reactive

* test(navbar): update snapshot

* chore: publish v0.33.0 (#1378)

* chore: publish v0.33.0

* chore: changelog's changes

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Co-authored-by: Y <anly_yaw@163.com>
Co-authored-by: Lzzzz <lz_n10828@163.com>
Co-authored-by: 龙风 <455947455@qq.com>
Co-authored-by: Jason <jason.daurus@gmail.com>
Co-authored-by: 大补 <38815121+AuYuHui@users.noreply.github.com>
Co-authored-by: byqbai <byq1213@qq.com>
Co-authored-by: lsdyi <52379902+lsdyi@users.noreply.github.com>
Co-authored-by: lsdyi <yangjinzhehao123@outlook.com>
Co-authored-by: Lindddt <44339196+Lindddt@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 无障碍访问
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DropdownMenu] 无障碍支持
3 participants