Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawer): support aria #1552

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Conversation

zhangpaopao0609
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 新特性提交

🔗 相关 Issue

fix #1057

💡 需求背景和解决方案

ios 录屏

📝 更新日志

  • feat(Drawer): 支持无障碍访问

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@LeeJim LeeJim added the a11y 无障碍访问 label Feb 3, 2023
@syxysszyw
Copy link
Collaborator

预览1

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

qrcode

@syxysszyw
Copy link
Collaborator

预览1

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

qrcode

@syxysszyw
Copy link
Collaborator

真机体验目前安卓下存在焦点穿透问题(录屏如下),苹果下蒙层无法获取焦点

80_1675655566.mp4

@syxysszyw
Copy link
Collaborator

真机体验目前安卓下存在焦点穿透问题(录屏如下),苹果下蒙层无法获取焦点

这里依赖Popup组件

src/drawer/drawer.wxml Outdated Show resolved Hide resolved
Copy link
Collaborator

@syxysszyw syxysszyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim LeeJim merged commit c66e214 into Tencent:develop Feb 14, 2023
LeeJim added a commit that referenced this pull request Feb 14, 2023
* Fix/upload/slot (#1507)

* fix(upload): update add-content slot

* docs(upload): update add-content description

* fix(upload): enable add-content property

* fix(cascader): enable multiple slot (#1508)

* feat(picker): upate ux (#1513)

* feat(picker): upate ux

* test: update snapshot

* chore: update qrcode (#1503)

* docs: add faq for image (#1512)

* docs: add faq for image

* docs: update faq

* feat(Cell): enrich CSS Variables (#1515)

* feat(Cell): enrich CSS Variables

* fix(Cell): fix cr

* fix(dialog): remove built-in input style (#1516)

* fix(dialog): remove built-in input style

* test: update snapshot

* feat(input): add new css variables

* feat(Cell): enrich CSS Variables (#1517)

* feat(NoticeBar): update demo (#1514)

* feat(NoticeBar): update demo

* fix(NoticeBar): fix cr

* fix(Swiper): fix swiper-item switching error when autoplay state (#1494)

* fix(Swiper): fix swiper-item switching error when autoplay state

* fix(Swiper): fix cr

* feat(sidebar): finish support icon (#1520)

* Feat/tabs/add icon (#1519)

* feat(tabs): support icon

* feat(tabs): finish support icon

* docs: update intro

* test(tabs): update snapshot

* chore: publish v1.0.0-rc.1 (#1522)

* docs: update changelog

* fix(navbar): add height for root element (#1526)

* fix(Search): fix slot name error (#1529)

* Fix/navbar/height (#1528)

* fix(navbar): add height for root element

* fix(navbar): remove uesless css

* feat(loading): support aria (#1534)

* feat(loading): loading support aira

* test: update snap

* feat: 备选方案WIP

* test: update snap

* feat(Checkbox&&Button): enrich css variable (#1530)

* feat(Checkbox&&Button): enrich css variable

* fix: fix cr

* fix: resolve slot (#1539)

* fix: resolve slot

* fix: using slot correctly

* docs(backtop): update icon

* fix(image-viewer): update slot render logic & event params (#1544)

* refactor: support both style and customStyle property (#1532)

* refactor: support both style and customStyle property

* test: add style and customStyle attribute unit test

* test: update jest config

---------

Co-authored-by: anlyyao <anly_yaw@163.com>

* docs(image): update api for slot (#1549)

* fix: fix console warnings caused by template (#1548)

* fix: fix console warnings caused by template

* test: update snapshots

* fix: fix cr

* fix(Progress): resolve text error for demo

* chore(Icon): update default value of the color and size attr to an empty string (#1553)

* fix: 组件引用路径改成相对路径 (#1551)

Co-authored-by: walkerliu <upliushuai@qq.com>

* fix(Calendar): remove the outline style of the tabindex element (#1573)

* feat(Input): support for slots named tips (#1572)

* fix(Button): fix css variable naming errors (#1563)

* docs: add custom-style (#1581)

* fix: resolve console warnings (#1586)

* fix: resolve console warnings

* test(notice-bar): update snapshot

* fix(radio): resolve console warnings

* fix(calendar): remove condition of title slot (#1588)

* feat: add submodule (#1589)

* feat: add submodule

* build: ignore _common dir

* chore: publish v1.0.0-rc.2 (#1590)

* docs: add changelog

* feat(sidebar): support aria (#1554)

* feat(sidebar): support aria

* feat(sidebar): update snap

* feat(drawer): support aria (#1552)

* feat(drawer): support aria

* feat(drawer): support ariarole

---------

Co-authored-by: Y <anly_yaw@163.com>
Co-authored-by: 龙风 <455947455@qq.com>
Co-authored-by: Walker <574991520@qq.com>
Co-authored-by: walkerliu <upliushuai@qq.com>
Co-authored-by: zhangpaopao <zhangpaopao0609@gmail.com>
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y 无障碍访问
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drawer] 无障碍支持
3 participants