feat(image-viewer): image-viewer 支持无障 碍模式 #1715
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
预览3 |
|
|
syxysszyw
reviewed
Mar 3, 2023
src/image-viewer/image-viewer.wxml
Outdated
| @@ -22,7 +24,7 @@ | |||
| current="{{currentSwiperIndex}}" | |||
| bindchange="onSwiperChange" | |||
| > | |||
| <swiper-item wx:for="{{images}}" wx:key="index" class="{{classPrefix}}__preview-image"> | |||
| <swiper-item wx:for="{{images}}" wx:key="index" class="{{classPrefix}}__preview-image" ria-role="img" aria-label="图像"> | |||
| <t-image | |||
There was a problem hiding this comment.
ria-role="img" aria-label="图像"为什么是定义在<swiper-item />上？从代码上看，里面有一个t-image- 应该是 aria-role 而非 ria-role
There was a problem hiding this comment.
里面有个t-image有自己的无障碍属性，是不是不用加到上了？
There was a problem hiding this comment.
示例中有多张图像，是不是可以通过图像1、图像2...来适当区分
There was a problem hiding this comment.
“不用加到上”是指什么？
不用加在 swiper-item上
There was a problem hiding this comment.
具体什么机型，我测试是通过的
iPhone 11 Pro，iOS 16.3
There was a problem hiding this comment.
不用加在 swiper-item上
如果需要加 aria-role=img，从代码看起来应该加在 t-image 上才比较合理
|
焦点穿透问题依旧存在哦 |
|
|
|
预览1 |
|
|
|
预览1 |
|
|
|
预览4 |
|
|
syxysszyw
reviewed
Mar 16, 2023
| @@ -32,12 +34,14 @@ | |||
| data-index="{{index}}" | |||
| class="{{classPrefix}}__image" | |||
| bindload="onImageLoadSuccess" | |||
| aria-role="img" | |||
| :aria-label="图像{{index}}" | |||
|
预览2 |
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #1062
💡 需求背景和解决方案
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单
andriod设备录屏
https://share.weiyun.com/lCbJwA6F
ios设备录屏
https://share.weiyun.com/ezpL6yyU