feat(slider): fix incorrect dot pos caused by repeated init #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
each time init is called, the dots are set to the defaultValue position. Added a flag to filter fix Tencent#3083
jby0107
requested review from
anlyyao,
jarmywang,
jin0209 and
betavs
as code owners
|
@jby0107 建议在文档FAQ加上一句：“（在t-popup/t-dialog中同理）” |
jarmywang
approved these changes
Aug 20, 2024
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
fix #3083
💡 需求背景和解决方案
通过在init中加入了一个flag检查来解决这个问题，检查是否已经初始化过，如果已经初始化就直接return。
📝 更新日志
fix(Slider): 修复
hidden为false场景下，调用init()函数更新组件时点位置错误本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单