Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backtop): correct classname #35

Merged
merged 1 commit into from
Dec 22, 2021
Merged

fix(backtop): correct classname #35

merged 1 commit into from
Dec 22, 2021

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Dec 22, 2021

Backtop: 纠正 classname

@LeeJim LeeJim requested a review from jin0209 December 22, 2021 07:41
padding: 0;
margin-top: 0;
}
}

&.round,
&.half-round {
&.@{prefix}-is-round,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@{prefix}--round

&.round,
&.half-round {
&.@{prefix}-is-round,
&.@{prefix}-is-half-round {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@{prefix}--half-round

<t-icon wx:if="{{!!icon}}" class="icon t-class-icon" name="{{icon}}" />
<view wx:if="{{ !!text }}" class="text t-class-text"> {{ text }} </view>
<view
class="{{prefix}}-class {{classPrefix}} {{fixed ? prefix + '-is-fixed' : ''}} {{prefix + '-is-' + theme}}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{classPrefix + '--' + theme}}

@LeeJim
Copy link
Collaborator Author

LeeJim commented Dec 22, 2021

我参考的是 TDesign 命名规范

image

Copy link
Collaborator

@jin0209 jin0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jin0209 jin0209 merged commit 3d9a274 into develop Dec 22, 2021
@jin0209 jin0209 deleted the fix/backtop/classname branch December 22, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants