Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): causes clicking on the overlay to trigger the close event #566

Merged
merged 1 commit into from
Jul 1, 2022
Merged

fix(dialog): causes clicking on the overlay to trigger the close event #566

merged 1 commit into from
Jul 1, 2022

Conversation

LeeJim
Copy link
Collaborator

@LeeJim LeeJim commented Jul 1, 2022

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

fix #563

💡 需求背景和解决方案

📝 更新日志

  • fix(Dialog): 修复点击遮罩层不会触发 close 事件的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2022

Size Change: +9 B (0%)

Total Size: 143 kB

Filename Size Change
./miniprogram_dist/dialog/dialog.wxml 902 B +9 B (+1%)
ℹ️ View Unchanged
Filename Size
./miniprogram_dist/action-sheet/action-sheet.js 1.1 kB
./miniprogram_dist/action-sheet/action-sheet.json 147 B
./miniprogram_dist/action-sheet/action-sheet.wxml 511 B
./miniprogram_dist/action-sheet/action-sheet.wxs 253 B
./miniprogram_dist/action-sheet/index.js 79 B
./miniprogram_dist/action-sheet/props.js 203 B
./miniprogram_dist/action-sheet/show.js 462 B
./miniprogram_dist/action-sheet/template/action-sheet-grid.wxml 514 B
./miniprogram_dist/action-sheet/template/action-sheet-item.wxml 285 B
./miniprogram_dist/action-sheet/template/action-sheet-list.wxml 240 B
./miniprogram_dist/action-sheet/type.js 31 B
./miniprogram_dist/avatar/avatar-group-props.js 170 B
./miniprogram_dist/avatar/avatar-group.js 1.12 kB
./miniprogram_dist/avatar/avatar-group.json 80 B
./miniprogram_dist/avatar/avatar-group.wxml 367 B
./miniprogram_dist/avatar/avatar-group.wxs 291 B
./miniprogram_dist/avatar/avatar.js 829 B
./miniprogram_dist/avatar/avatar.json 106 B
./miniprogram_dist/avatar/avatar.wxml 504 B
./miniprogram_dist/avatar/avatar.wxs 429 B
./miniprogram_dist/avatar/props.js 194 B
./miniprogram_dist/avatar/type.js 31 B
./miniprogram_dist/back-top/back-top.js 605 B
./miniprogram_dist/back-top/back-top.json 81 B
./miniprogram_dist/back-top/back-top.wxml 193 B
./miniprogram_dist/back-top/props.js 164 B
./miniprogram_dist/back-top/type.js 33 B
./miniprogram_dist/badge/badge.js 569 B
./miniprogram_dist/badge/badge.json 60 B
./miniprogram_dist/badge/badge.wxml 333 B
./miniprogram_dist/badge/badge.wxs 477 B
./miniprogram_dist/badge/index.js 60 B
./miniprogram_dist/badge/props.js 227 B
./miniprogram_dist/badge/type.js 33 B
./miniprogram_dist/behaviors/dom.js 297 B
./miniprogram_dist/behaviors/touch.js 340 B
./miniprogram_dist/button-group/button-group.js 365 B
./miniprogram_dist/button-group/button-group.json 59 B
./miniprogram_dist/button-group/button-group.wxml 64 B
./miniprogram_dist/button/button.js 1 kB
./miniprogram_dist/button/button.json 81 B
./miniprogram_dist/button/button.wxml 569 B
./miniprogram_dist/button/index.js 62 B
./miniprogram_dist/button/props.js 370 B
./miniprogram_dist/button/type.js 31 B
./miniprogram_dist/cell-group/cell-group.js 550 B
./miniprogram_dist/cell-group/cell-group.json 44 B
./miniprogram_dist/cell-group/cell-group.wxml 134 B
./miniprogram_dist/cell-group/props.js 148 B
./miniprogram_dist/cell-group/type.js 33 B
./miniprogram_dist/cell/cell.js 709 B
./miniprogram_dist/cell/cell.json 81 B
./miniprogram_dist/cell/cell.wxml 479 B
./miniprogram_dist/cell/props.js 237 B
./miniprogram_dist/cell/type.js 31 B
./miniprogram_dist/checkbox-group/checkbox-group.js 1.61 kB
./miniprogram_dist/checkbox-group/checkbox-group.json 85 B
./miniprogram_dist/checkbox-group/checkbox-group.wxml 255 B
./miniprogram_dist/checkbox/checkbox-group-props.js 178 B
./miniprogram_dist/checkbox/checkbox.js 1.06 kB
./miniprogram_dist/checkbox/checkbox.json 94 B
./miniprogram_dist/checkbox/checkbox.wxml 576 B
./miniprogram_dist/checkbox/props.js 300 B
./miniprogram_dist/checkbox/type.js 31 B
./miniprogram_dist/collapse/collapse-panel-props.js 197 B
./miniprogram_dist/collapse/collapse-panel.js 1.35 kB
./miniprogram_dist/collapse/collapse-panel.json 81 B
./miniprogram_dist/collapse/collapse-panel.wxml 461 B
./miniprogram_dist/collapse/collapse.js 904 B
./miniprogram_dist/collapse/collapse.json 44 B
./miniprogram_dist/collapse/collapse.wxml 115 B
./miniprogram_dist/collapse/index.js 94 B
./miniprogram_dist/collapse/props.js 160 B
./miniprogram_dist/collapse/type.js 31 B
./miniprogram_dist/common/common.js 31 B
./miniprogram_dist/common/component.js 153 B
./miniprogram_dist/common/config.js 55 B
./miniprogram_dist/common/src/control.js 498 B
./miniprogram_dist/common/src/flatTool.js 756 B
./miniprogram_dist/common/src/index.js 98 B
./miniprogram_dist/common/src/instantiationDecorator.js 1.06 kB
./miniprogram_dist/common/src/superComponent.js 94 B
./miniprogram_dist/common/template/button.wxml 391 B
./miniprogram_dist/common/utils.js 1.15 kB
./miniprogram_dist/common/utils.wxs 392 B
./miniprogram_dist/common/version.js 376 B
./miniprogram_dist/count-down/count-down.js 1.07 kB
./miniprogram_dist/count-down/count-down.json 81 B
./miniprogram_dist/count-down/count-down.wxml 366 B
./miniprogram_dist/count-down/props.js 205 B
./miniprogram_dist/count-down/type.js 31 B
./miniprogram_dist/count-down/utils.js 679 B
./miniprogram_dist/date-time-picker/date-time-picker.js 3.04 kB
./miniprogram_dist/date-time-picker/date-time-picker.json 96 B
./miniprogram_dist/date-time-picker/date-time-picker.wxml 242 B
./miniprogram_dist/date-time-picker/locale/en.js 111 B
./miniprogram_dist/date-time-picker/locale/zh.js 144 B
./miniprogram_dist/date-time-picker/props.js 253 B
./miniprogram_dist/date-time-picker/type.js 31 B
./miniprogram_dist/dialog/dialog.js 1.05 kB
./miniprogram_dist/dialog/dialog.json 98 B
./miniprogram_dist/dialog/dialog.wxs 83 B
./miniprogram_dist/dialog/index.js 1.03 kB
./miniprogram_dist/dialog/props.js 286 B
./miniprogram_dist/dialog/type.js 31 B
./miniprogram_dist/divider/divider.js 568 B
./miniprogram_dist/divider/divider.json 44 B
./miniprogram_dist/divider/divider.wxml 244 B
./miniprogram_dist/divider/props.js 187 B
./miniprogram_dist/divider/type.js 33 B
./miniprogram_dist/drawer/drawer.js 698 B
./miniprogram_dist/drawer/drawer.json 95 B
./miniprogram_dist/drawer/drawer.wxml 313 B
./miniprogram_dist/drawer/props.js 205 B
./miniprogram_dist/drawer/type.js 31 B
./miniprogram_dist/dropdown-menu/dropdown-item-props.js 217 B
./miniprogram_dist/dropdown-menu/dropdown-item.js 1.86 kB
./miniprogram_dist/dropdown-menu/dropdown-item.json 158 B
./miniprogram_dist/dropdown-menu/dropdown-item.wxml 1.15 kB
./miniprogram_dist/dropdown-menu/dropdown-menu.js 928 B
./miniprogram_dist/dropdown-menu/dropdown-menu.json 81 B
./miniprogram_dist/dropdown-menu/dropdown-menu.wxml 302 B
./miniprogram_dist/dropdown-menu/index.js 77 B
./miniprogram_dist/dropdown-menu/props.js 193 B
./miniprogram_dist/dropdown-menu/type.js 31 B
./miniprogram_dist/dropdown-menu/util.wxs 123 B
./miniprogram_dist/empty/empty.js 559 B
./miniprogram_dist/empty/empty.json 81 B
./miniprogram_dist/empty/empty.wxml 297 B
./miniprogram_dist/empty/empty.wxs 176 B
./miniprogram_dist/empty/props.js 137 B
./miniprogram_dist/empty/type.js 33 B
./miniprogram_dist/fab/fab.js 626 B
./miniprogram_dist/fab/fab.json 83 B
./miniprogram_dist/fab/fab.wxml 204 B
./miniprogram_dist/fab/props.js 155 B
./miniprogram_dist/fab/type.js 31 B
./miniprogram_dist/footer/footer.js 504 B
./miniprogram_dist/footer/footer.json 59 B
./miniprogram_dist/footer/footer.wxml 373 B
./miniprogram_dist/footer/props.js 149 B
./miniprogram_dist/footer/type.js 35 B
./miniprogram_dist/grid/grid-item-props.js 176 B
./miniprogram_dist/grid/grid-item.js 1.26 kB
./miniprogram_dist/grid/grid-item.json 82 B
./miniprogram_dist/grid/grid-item.wxml 417 B
./miniprogram_dist/grid/grid.js 881 B
./miniprogram_dist/grid/grid.json 59 B
./miniprogram_dist/grid/grid.wxml 103 B
./miniprogram_dist/grid/props.js 200 B
./miniprogram_dist/grid/type.js 35 B
./miniprogram_dist/icon/icon.js 724 B
./miniprogram_dist/icon/icon.json 59 B
./miniprogram_dist/icon/icon.wxml 172 B
./miniprogram_dist/icon/props.js 150 B
./miniprogram_dist/icon/type.js 31 B
./miniprogram_dist/image-viewer/image-viewer.js 1.28 kB
./miniprogram_dist/image-viewer/image-viewer.json 118 B
./miniprogram_dist/image-viewer/image-viewer.wxml 591 B
./miniprogram_dist/image-viewer/props.js 233 B
./miniprogram_dist/image-viewer/type.js 31 B
./miniprogram_dist/image/image-info.json 719 B
./miniprogram_dist/image/image.js 1.14 kB
./miniprogram_dist/image/image.json 96 B
./miniprogram_dist/image/image.wxml 529 B
./miniprogram_dist/image/index.js 55 B
./miniprogram_dist/image/props.js 205 B
./miniprogram_dist/image/type.js 31 B
./miniprogram_dist/indexes/indexes.js 1.7 kB
./miniprogram_dist/indexes/indexes.json 108 B
./miniprogram_dist/indexes/indexes.wxml 558 B
./miniprogram_dist/indexes/props.js 125 B
./miniprogram_dist/indexes/type.js 35 B
./miniprogram_dist/input/input.js 917 B
./miniprogram_dist/input/input.json 94 B
./miniprogram_dist/input/input.wxml 935 B
./miniprogram_dist/input/props.js 520 B
./miniprogram_dist/input/type.js 31 B
./miniprogram_dist/loading/index.js 63 B
./miniprogram_dist/loading/loading.js 768 B
./miniprogram_dist/loading/loading.json 59 B
./miniprogram_dist/loading/loading.wxml 735 B
./miniprogram_dist/loading/props.js 253 B
./miniprogram_dist/loading/type.js 31 B
./miniprogram_dist/message/index.js 530 B
./miniprogram_dist/message/message.interface.js 133 B
./miniprogram_dist/message/message.js 1.83 kB
./miniprogram_dist/message/message.json 94 B
./miniprogram_dist/message/message.wxml 523 B
./miniprogram_dist/message/message.wxs 238 B
./miniprogram_dist/message/props.js 269 B
./miniprogram_dist/message/type.js 35 B
./miniprogram_dist/miniprogram_npm/dayjs/index.js 2.9 kB
./miniprogram_dist/navbar/navbar.js 1.65 kB
./miniprogram_dist/navbar/navbar.json 81 B
./miniprogram_dist/navbar/navbar.wxml 552 B
./miniprogram_dist/navbar/props.js 212 B
./miniprogram_dist/navbar/type.js 31 B
./miniprogram_dist/notice-bar/notice-bar.js 1.71 kB
./miniprogram_dist/notice-bar/notice-bar.json 94 B
./miniprogram_dist/notice-bar/notice-bar.wxml 355 B
./miniprogram_dist/notice-bar/props.js 196 B
./miniprogram_dist/notice-bar/type.js 31 B
./miniprogram_dist/overlay/overlay.js 730 B
./miniprogram_dist/overlay/overlay.json 44 B
./miniprogram_dist/overlay/overlay.wxml 246 B
./miniprogram_dist/picker/picker-item-props.js 110 B
./miniprogram_dist/picker/picker-item.js 1.34 kB
./miniprogram_dist/picker/picker-item.json 59 B
./miniprogram_dist/picker/picker-item.wxml 295 B
./miniprogram_dist/picker/picker.js 1.09 kB
./miniprogram_dist/picker/picker.json 82 B
./miniprogram_dist/picker/picker.wxml 310 B
./miniprogram_dist/picker/props.js 199 B
./miniprogram_dist/picker/type.js 31 B
./miniprogram_dist/popup/popup.js 930 B
./miniprogram_dist/popup/popup.json 99 B
./miniprogram_dist/popup/popup.wxml 364 B
./miniprogram_dist/popup/props.js 258 B
./miniprogram_dist/popup/type.js 35 B
./miniprogram_dist/progress/progress.js 720 B
./miniprogram_dist/progress/progress.json 59 B
./miniprogram_dist/progress/progress.wxml 280 B
./miniprogram_dist/progress/props.js 199 B
./miniprogram_dist/progress/type.js 31 B
./miniprogram_dist/progress/utils.js 591 B
./miniprogram_dist/pull-down-refresh/props.js 238 B
./miniprogram_dist/pull-down-refresh/pull-down-refresh.js 1.52 kB
./miniprogram_dist/pull-down-refresh/pull-down-refresh.json 83 B
./miniprogram_dist/pull-down-refresh/pull-down-refresh.wxml 556 B
./miniprogram_dist/pull-down-refresh/type.js 31 B
./miniprogram_dist/radio-group/radio-group.js 1.16 kB
./miniprogram_dist/radio-group/radio-group.json 82 B
./miniprogram_dist/radio-group/radio-group.wxml 200 B
./miniprogram_dist/radio/props.js 300 B
./miniprogram_dist/radio/radio-group-props.js 183 B
./miniprogram_dist/radio/radio.js 1.13 kB
./miniprogram_dist/radio/radio.json 94 B
./miniprogram_dist/radio/radio.wxml 515 B
./miniprogram_dist/radio/type.js 31 B
./miniprogram_dist/rate/props.js 252 B
./miniprogram_dist/rate/rate.js 1.13 kB
./miniprogram_dist/rate/rate.json 81 B
./miniprogram_dist/rate/rate.wxml 424 B
./miniprogram_dist/rate/rate.wxs 515 B
./miniprogram_dist/rate/type.js 31 B
./miniprogram_dist/search/props.js 213 B
./miniprogram_dist/search/search.js 813 B
./miniprogram_dist/search/search.json 81 B
./miniprogram_dist/search/search.wxml 552 B
./miniprogram_dist/search/type.js 31 B
./miniprogram_dist/skeleton/props.js 182 B
./miniprogram_dist/skeleton/skeleton.js 819 B
./miniprogram_dist/skeleton/skeleton.json 59 B
./miniprogram_dist/skeleton/skeleton.wxml 401 B
./miniprogram_dist/skeleton/type.js 35 B
./miniprogram_dist/slider/props.js 306 B
./miniprogram_dist/slider/slider.js 2.57 kB
./miniprogram_dist/slider/slider.json 59 B
./miniprogram_dist/slider/slider.wxml 995 B
./miniprogram_dist/slider/slider.wxs 177 B
./miniprogram_dist/slider/tool.js 253 B
./miniprogram_dist/slider/type.js 31 B
./miniprogram_dist/stepper/props.js 230 B
./miniprogram_dist/stepper/stepper.js 1.06 kB
./miniprogram_dist/stepper/stepper.json 94 B
./miniprogram_dist/stepper/stepper.wxml 406 B
./miniprogram_dist/stepper/type.js 31 B
./miniprogram_dist/steps/props.js 218 B
./miniprogram_dist/steps/step-item-props.js 167 B
./miniprogram_dist/steps/step-item.js 1.68 kB
./miniprogram_dist/steps/step-item.json 81 B
./miniprogram_dist/steps/step-item.wxml 754 B
./miniprogram_dist/steps/steps.js 981 B
./miniprogram_dist/steps/steps.json 83 B
./miniprogram_dist/steps/steps.wxml 130 B
./miniprogram_dist/steps/type.js 31 B
./miniprogram_dist/sticky/props.js 170 B
./miniprogram_dist/sticky/sticky.js 1.28 kB
./miniprogram_dist/sticky/sticky.json 59 B
./miniprogram_dist/sticky/sticky.wxml 136 B
./miniprogram_dist/sticky/type.js 33 B
./miniprogram_dist/sticky/utils.js 535 B
./miniprogram_dist/swipe-cell/props.js 148 B
./miniprogram_dist/swipe-cell/swipe-cell.js 1.15 kB
./miniprogram_dist/swipe-cell/swipe-cell.json 44 B
./miniprogram_dist/swipe-cell/swipe-cell.wxml 408 B
./miniprogram_dist/swipe-cell/swipe-cell.wxs 1.47 kB
./miniprogram_dist/swipe-cell/type.js 35 B
./miniprogram_dist/swiper/common/constants.js 89 B
./miniprogram_dist/swiper/props.js 207 B
./miniprogram_dist/swiper/swiper-item.js 645 B
./miniprogram_dist/swiper/swiper-item.json 44 B
./miniprogram_dist/swiper/swiper-item.wxml 104 B
./miniprogram_dist/swiper/swiper-nav.js 869 B
./miniprogram_dist/swiper/swiper-nav.json 44 B
./miniprogram_dist/swiper/swiper-nav.wxml 300 B
./miniprogram_dist/swiper/swiper.js 2.17 kB
./miniprogram_dist/swiper/swiper.json 95 B
./miniprogram_dist/swiper/swiper.wxml 636 B
./miniprogram_dist/swiper/swiper.wxs 1.36 kB
./miniprogram_dist/swiper/type.js 35 B
./miniprogram_dist/switch/props.js 216 B
./miniprogram_dist/switch/switch.js 928 B
./miniprogram_dist/switch/switch.json 59 B
./miniprogram_dist/switch/switch.wxml 230 B
./miniprogram_dist/switch/type.js 31 B
./miniprogram_dist/tab-bar/props.js 246 B
./miniprogram_dist/tab-bar/tab-bar-item-props.js 153 B
./miniprogram_dist/tab-bar/tab-bar-item.js 1.06 kB
./miniprogram_dist/tab-bar/tab-bar-item.json 95 B
./miniprogram_dist/tab-bar/tab-bar-item.wxml 546 B
./miniprogram_dist/tab-bar/tab-bar.js 924 B
./miniprogram_dist/tab-bar/tab-bar.json 86 B
./miniprogram_dist/tab-bar/tab-bar.wxml 136 B
./miniprogram_dist/tab-bar/type.js 31 B
./miniprogram_dist/tabs/props.js 203 B
./miniprogram_dist/tabs/tab-panel-props.js 168 B
./miniprogram_dist/tabs/tab-panel.js 700 B
./miniprogram_dist/tabs/tab-panel.json 59 B
./miniprogram_dist/tabs/tab-panel.wxml 202 B
./miniprogram_dist/tabs/tabs.js 2.1 kB
./miniprogram_dist/tabs/tabs.json 44 B
./miniprogram_dist/tabs/tabs.wxml 461 B
./miniprogram_dist/tabs/tabs.wxs 288 B
./miniprogram_dist/tabs/type.js 31 B
./miniprogram_dist/tag/check-tag-props.js 214 B
./miniprogram_dist/tag/check-tag.js 660 B
./miniprogram_dist/tag/check-tag.json 83 B
./miniprogram_dist/tag/check-tag.wxml 250 B
./miniprogram_dist/tag/check-tag.wxs 400 B
./miniprogram_dist/tag/props.js 223 B
./miniprogram_dist/tag/tag.js 573 B
./miniprogram_dist/tag/tag.json 83 B
./miniprogram_dist/tag/tag.wxml 310 B
./miniprogram_dist/tag/tag.wxs 493 B
./miniprogram_dist/tag/type.js 31 B
./miniprogram_dist/textarea/props.js 249 B
./miniprogram_dist/textarea/textarea.js 944 B
./miniprogram_dist/textarea/textarea.json 59 B
./miniprogram_dist/textarea/textarea.wxml 418 B
./miniprogram_dist/textarea/type.js 31 B
./miniprogram_dist/toast/index.js 668 B
./miniprogram_dist/toast/props.js 242 B
./miniprogram_dist/toast/toast.js 1.01 kB
./miniprogram_dist/toast/toast.json 111 B
./miniprogram_dist/toast/toast.wxml 517 B
./miniprogram_dist/toast/type.js 31 B
./miniprogram_dist/transition/props.js 176 B
./miniprogram_dist/transition/transition.js 949 B
./miniprogram_dist/transition/transition.json 59 B
./miniprogram_dist/transition/transition.wxml 161 B
./miniprogram_dist/transition/type.js 33 B
./miniprogram_dist/upload/props.js 285 B
./miniprogram_dist/upload/type.js 31 B
./miniprogram_dist/upload/upload-info.json 1.34 kB
./miniprogram_dist/upload/upload.js 2.34 kB
./miniprogram_dist/upload/upload.json 125 B
./miniprogram_dist/upload/upload.wxml 812 B

@LeeJim LeeJim merged commit 08a1fe9 into develop Jul 1, 2022
@LeeJim LeeJim deleted the fix/dialog/click-on-overlay branch July 1, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@LeeJim