Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): 解决tabs左右滑动时不会触发change事件的BUG, fixes #64 #65

Merged
merged 3 commits into from
Jan 4, 2022
Merged

fix(tabs): 解决tabs左右滑动时不会触发change事件的BUG, fixes #64 #65

merged 3 commits into from
Jan 4, 2022

Conversation

beancookie
Copy link
Contributor

No description provided.

LeeJim
LeeJim approved these changes Dec 31, 2021
View reviewed changes
Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim
Copy link
Collaborator

LeeJim commented Dec 31, 2021 •
edited
Loading

代码没什么问题。
提交的规范需要注意一下：

  • commit message 要全英文
  • commit message 中应该是 fixes #64，不需要 Tencent

使用 git commit --amend 修改下 commit message 吧。我再合并进去

@beancookie beancookie closed this Dec 31, 2021
@beancookie
Copy link
Contributor Author

感谢提醒，已经把commit message修改成英文了

@LeeJim
Copy link
Collaborator

LeeJim commented Dec 31, 2021

为什么 close 了？

@beancookie beancookie reopened this Jan 4, 2022
@beancookie
Copy link
Contributor Author

不小心点错了

@JJunYang
Copy link
Contributor

JJunYang commented Jan 4, 2022

eslint 校验失败，看看这个console.log问题，不能去除的话，建议这文件忽略console校验
截屏2022-01-04 上午9 58 45

@JJunYang JJunYang linked an issue Jan 4, 2022 that may be closed by this pull request
t-tabs 左右滑动时不会触发change事件 #64
Closed
@LeeJim LeeJim merged commit 2850bec into Tencent:develop Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeJim LeeJim LeeJim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

t-tabs 左右滑动时不会触发change事件
3 participants
@beancookie @LeeJim @JJunYang