Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(avatar): add unit test #812

Merged
merged 7 commits into from
Aug 31, 2022
Merged

Conversation

Perisiguiendo
Copy link
Contributor

@Perisiguiendo Perisiguiendo commented Aug 30, 2022

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • test(Avatar): 新增单元测试

@LeeJim
Copy link
Collaborator

LeeJim commented Aug 30, 2022

CI挂了,rebase develop 就好了

@LeeJim
Copy link
Collaborator

LeeJim commented Aug 30, 2022

event.test.js 可以合并到 index 里面,保持和其他组件一致的写法

@LeeJim
Copy link
Collaborator

LeeJim commented Aug 31, 2022

怎么移除了 event?
我的意思是合并到 index 里,不要创建多个文件而已 :)

@Perisiguiendo
Copy link
Contributor Author

Perisiguiendo commented Aug 31, 2022

😥看错了,已修改,辛苦在review下

Copy link
Collaborator

@LeeJim LeeJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeJim LeeJim merged commit cc4e882 into Tencent:develop Aug 31, 2022
@LeeJim LeeJim mentioned this pull request Aug 31, 2022
50 tasks
@github-actions github-actions bot mentioned this pull request Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants