pref: 优化修改主题色的逻辑 #428
Merged
pref: 优化修改主题色的逻辑 #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
timi137137
approved these changes
Feb 20, 2023
|
@uyarn LGTM,but not test |
uyarn
requested changes
Feb 21, 2023
|
ok。我看一下 |
hzgotb
force-pushed
the
feature/optimize-modify-theme-color-logic
branch
from
c916c99 to
975b845
Compare
|
@uyarn 可以了。因为对颜色做了计算缓存，所以在切换其他模式的时候判断存在色阶所以不再计算。我改了一下判断的key |
uyarn
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
setting组件和setting store 有相同的逻辑代码，简化了一下。
📝 更新日志
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单