Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 新增侧边栏颜色切换 #681

Merged
merged 5 commits into from
Feb 14, 2024
Merged

feat: 新增侧边栏颜色切换 #681

merged 5 commits into from
Feb 14, 2024

Conversation

timi137137
Copy link
Collaborator

@timi137137 timi137137 commented Feb 13, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

closed #447
link #657

💡 需求背景和解决方案

📝 更新日志

⚠️ Breaking Change: 配置文件有新增和修改,该操作为BC操作,出现样式异常请尝试clear local storge⚠️

  • feat: 新增侧边栏颜色切换

  • fix: 修复头部元素与Logo偏移的问题

  • fix: 修复部分i18n未引用的问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@timi137137 timi137137 requested a review from uyarn February 13, 2024 13:09
Copy link
Contributor

github-actions bot commented Feb 13, 2024

完成

<p :style="{ textAlign: 'center', marginTop: '8px' }">{{ item.text }}</p>
</div>
</div>
</t-radio-group>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉这个其实做成个radiogroup就可以 一个暗黑一个明亮 这个侧边栏也再多个跟随系统 跟随系统感觉是全局的 单独一个侧边栏有这种配置 不太合适

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit cd6e478, 经过测试,只能禁用掉跟随系统按钮。否则就只能大改样式文件了,如果要改就肯定要写死margin left了,这是配置面板建议可以不用太要命(或者有什么更好的展示方式?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit 5606355, 现在好多了

@timi137137 timi137137 requested a review from uyarn February 13, 2024 18:54
@uyarn uyarn merged commit ce97b04 into develop Feb 14, 2024
4 checks passed
@timi137137 timi137137 deleted the feature/menu-black-mode branch February 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

能否左侧菜单增加深色调模式?
2 participants