fix(Form): fix Form scrollToFirstError bug #3251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningbao
requested review from
chaishi,
uyarn,
xiaosansiji,
maoyiluo,
liweijie0812 and
LoopZhou
as code owners
|
|
uyarn
changed the title
uyarn
approved these changes
Aug 3, 2024
Merged
16 tasks
uyarn
pushed a commit
that referenced
this pull request
Aug 15, 2024
* fix(Form): fix form-item class name and scrollToFirstError get form-item class name * fix(Form): fix form-item class name and scrollToFirstError get form-item class name * fix(Form): test update --------- Co-authored-by: v-tangchenw <v-tangchenw.gd@chinatelecom.cn>
uyarn
added a commit
that referenced
this pull request
Aug 15, 2024
* chore: modify TEST_GUIDE link (#3239) * fix(table): table.columns.thClassName doesn't work (#3198) (#3238) * fix(table): table.columns.thClassName doesn't work (#3198) fix #3198 * test(table): add missing test: thClassName * fix(Upload): fix global icon replacement (#3244) * feat(borderless): support borderless API (#3249) * docs(Input): value type remove Number * feat: support borderless mode * docs(auto-complete): update doc * feat(descriptions): make layout type to be multiple type (#3252) * fix(TagInput): tagProps should effect minCollapseNum tag (#3260) * fix(TagInput): tagProps should effect minCollapseNum tag * chore: fix lint * chore(deps-dev): bump @babel/helper-module-imports from 7.22.5 to 7.24.7 (#3259) Bumps [@babel/helper-module-imports](https://github.com/babel/babel/tree/HEAD/packages/babel-helper-module-imports) from 7.22.5 to 7.24.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.7/packages/babel-helper-module-imports) --- updated-dependencies: - dependency-name: "@babel/helper-module-imports" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(Form): fix Form scrollToFirstError bug (#3251) * fix(Form): fix form-item class name and scrollToFirstError get form-item class name * fix(Form): fix form-item class name and scrollToFirstError get form-item class name * fix(Form): test update --------- Co-authored-by: v-tangchenw <v-tangchenw.gd@chinatelecom.cn> * chore: remove ghost config from live demo (#3265) * chore: update common (#3273) * chore: update common * fix(cascader): fix remove and change trigger effect * chore: release 1.9.9 (#3274) * chore: release 1.9.9 * chore: changelog's changes --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * chore: release 1.9.9-naruto * chore: release 1.9.9-naruto --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: theBestVayne <32293224+theBestVayne@users.noreply.github.com> Co-authored-by: liweijie0812 <674416404@qq.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: MorningUei <747651423@qq.com> Co-authored-by: v-tangchenw <v-tangchenw.gd@chinatelecom.cn> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tem class name
🤔 这个 PR 的性质是？
🔗 相关 Issue
#3247
💡 需求背景和解决方案
在循环使用form-item的情况下，name支持arr[0]数组索引式读取，obj.field对象属性读取。
但是form-item的classname依赖name属性来做dom搜索的功能，但是selector规范不允许[]，以及会因为 . 而误判。最终就会导致以上issue里scrollToFirstError功能的报错而失效。
📝 更新日志
fix(Form): 修复某种情况下scrollToFirstError失效的问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单