fix: 修复window被proxy,导致作用域错误 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
存储用个set不可以嘛.. 毕竟这个true也不需要使用 |
yiludege
reviewed
Aug 30, 2022
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
对于已经 算过的 boundValue 也可以放到缓存中，下次不用再bind，直接从缓存拿？
There was a problem hiding this comment.
所以这个地方的 weakmap key 为原始的函数，value为 bind 之后的函数 boundValue
Heath1998
force-pushed
the
fix/window-proxy-error
branch
from
25efbbe
to
93e61f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run test通过详细描述