fix: 修复 子应用 html 上的属性会被丢失的问题(#908) #909
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J10240221
commented
Oct 8, 2024
| const parsedDocument = parser.parseFromString(template, "text/html"); | ||
|
|
||
| // 无论 template 是否包含html，documentElement 必然是 HTMLHtmlElement | ||
| let html = parsedDocument.documentElement as HTMLHtmlElement; |
There was a problem hiding this comment.
经过chrome检验， 无论template中是否有html标签，parsedDocument instanceof HTMLDocument 都是true
|
@yiludege 大大，麻烦看下这个issue 和解决的pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test通过详细描述