fix: time.Ticker没有关闭，导致cpu使用率过高 #478

bcs-common/common/blog/glog/glog.go

@@ -886,7 +886,9 @@ const flushInterval = 30 * time.Second
 
 // flushDaemon periodically flushes the log file buffers.
 func (l *loggingT) flushDaemon() {
-	for _ = range time.NewTicker(flushInterval).C {
+	ticker := time.NewTicker(flushInterval)
+	defer ticker.Stop()
+	for _ = range ticker.C {
 		l.lockAndFlushAll()
 	}
 }

bcs-common/pkg/master/zookeeper.go

@@ -263,6 +263,9 @@ func (zk *ZookeeperMaster) masterLoop() {
 func (zk *ZookeeperMaster) healthLoop() {
 	masterTick := time.NewTicker(time.Second * 2)
 	selfTick := time.NewTicker(time.Second * 30)
+	defer masterTick.Stop()
+	defer selfTick.Stop()
+
 	for {
 		select {
 		case <-zk.exitCxt.Done():

bcs-common/pkg/reflector/reflector.go

@@ -73,8 +73,10 @@ func (r *Reflector) Run() {
 	blog.V(3).Infof("%s first resynchronization & watch success, register all ticker", r.name)
 	//create ticker for data object resync
 	syncTick := time.NewTicker(r.syncPeriod)
+	defer syncTick.Stop()
 	//create ticker check stable watcher
 	watchTick := time.NewTicker(time.Second * 2)
+	defer watchTick.Stop()
 	for {
 		select {
 		case <-r.cxt.Done():

bcs-common/pkg/storage/zookeeper/util.go

@@ -115,6 +115,7 @@ func (n *Node) Run() {
 		go n.childrenLoop()
 	}
 	tick := time.NewTicker(time.Second * 3)
+	defer tick.Stop()
 	for {
 		if n.isStopped {
 			return
@@ -208,6 +209,7 @@ func (n *Node) selfLoop() {
 	}
 	//wait for next event
 	forceTick := time.NewTicker(time.Second * 300)
+	defer forceTick.Stop()
 	for {
 		select {
 		case <-n.watchCxt.Done():

bcs-k8s/bcs-k8s-csi-tencentcloud/driver/cbs/controller.go

@@ -297,6 +297,7 @@ func (ctrl *cbsController) CreateVolume(ctx context.Context, req *csi.CreateVolu
 	disk := new(cbs.Disk)
 
 	ticker := time.NewTicker(time.Second * 5)
+	defer ticker.Stop()
 
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*120)
 	defer cancel()

bcs-mesos/bcs-consoleproxy/console-proxy/manager/console.go

@@ -146,6 +146,7 @@ func (m *manager) StartExec(w http.ResponseWriter, r *http.Request, conf *types.
 	//})
 
 	ticker := time.NewTicker(pingPeriod)
+	defer ticker.Stop()
 	go func() {
 		for {
 			select {

bcs-mesos/bcs-container-executor/app/bcs_executor.go

@@ -359,6 +359,7 @@ func (executor *BcsExecutor) LaunchTaskGroup(driver exec.ExecutorDriver, taskGro
 	stopCh := make(chan struct{})
 	go func() {
 		ticker := time.NewTicker(time.Minute)
+		defer ticker.Stop()
 
 		for {
 			select {
@@ -580,6 +581,7 @@ func (executor *BcsExecutor) monitorPod() {
 	}()
 
 	tick := time.NewTicker(1 * time.Second)
+	defer tick.Stop()
 	reporting := 0
 	for {
 		select {

bcs-mesos/bcs-container-executor/connection/fakeconn.go

@@ -83,6 +83,7 @@ func (httpConn *FakeConnection) slaveSimulation() {
 	//send Shutdown in 10 second
 	//send KillTask in 10 second ?
 	tick := time.NewTicker(1 * time.Second)
+	defer tick.Stop()
 	fmt.Fprintln(os.Stdout, "enter slave message sending loop")
 	i := 0
 	for {

bcs-mesos/bcs-container-executor/container/cni/cni_pod.go

@@ -619,6 +619,7 @@ func (p *CNIPod) containersWatch(cxt context.Context) {
 	}
 
 	tick := time.NewTicker(defaultPodWatchInterval * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-cxt.Done():

bcs-mesos/bcs-container-executor/container/cnm/cnm_pod.go

@@ -569,6 +569,7 @@ func (p *DockerPod) containersWatch(cxt context.Context) {
 	}
 
 	tick := time.NewTicker(defaultPodWatchInterval * time.Second)
+	defer tick.Stop()
 	//total := defaultErrTolerate * len(p.runningContainer)
 	for {
 		select {

bcs-mesos/bcs-container-executor/executor/executor.go

@@ -343,7 +343,9 @@ func (driver *BcsExecutorDriver) Stop() (mesos.Status, error) {
 		logs.Infoln("ExecutorDriver is under connection, wait slave reply acknowledged")
 		//check all update info acknowledged
 		checkTick := time.NewTicker(500 * time.Microsecond)
+		defer checkTick.Stop()
 		timeoutTick := time.NewTicker(5 * time.Second)
+		defer timeoutTick.Stop()
 		for driver.updates != nil && driver.connected {
 			//if connection lost, no need to wait acknowledgement
 			select {

bcs-mesos/bcs-container-executor/healthcheck/cmd.go

@@ -86,6 +86,7 @@ func (check *CommandChecker) Start() {
 	check.check()
 
 	tick := time.NewTicker(time.Duration(int64(check.mechanism.IntervalSeconds)) * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-check.cxt.Done():

bcs-mesos/bcs-container-executor/healthcheck/http.go

@@ -88,6 +88,7 @@ func (check *HTTPChecker) Start() {
 	check.check()
 
 	tick := time.NewTicker(time.Duration(int64(check.mechanism.IntervalSeconds)) * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-check.cxt.Done():

bcs-mesos/bcs-container-executor/healthcheck/tcp.go

@@ -79,6 +79,7 @@ func (check *TCPChecker) Start() {
 	check.check()
 
 	tick := time.NewTicker(time.Duration(int64(check.mechanism.IntervalSeconds)) * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-check.cxt.Done():

bcs-mesos/bcs-hpacontroller/hpacontroller/controller/autoscaler.go

@@ -84,6 +84,7 @@ func (auto *Autoscaler) Start() error {
 //ticker list zk autoscalers and sync these autoscalers to workqueue
 func (auto *Autoscaler) tickerSyncAutoscalerQueue() {
 	ticker := time.NewTicker(time.Second * time.Duration(auto.config.MetricsSyncPeriod))
+	defer ticker.Stop()
 
 	for {
 
@@ -162,6 +163,7 @@ func (auto *Autoscaler) tickerSyncAutoscalerQueue() {
 
 func (auto *Autoscaler) tickerHandlerAutoscaler() {
 	ticker := time.NewTicker(time.Second * time.Duration(auto.config.MetricsSyncPeriod))
+	defer ticker.Stop()
 
 	for {
 

bcs-mesos/bcs-hpacontroller/hpacontroller/metrics/resources/resourcesCollector.go

@@ -116,6 +116,7 @@ func (collector *resourcesCollector) getMemoryMetricsInfo() metrics.TaskgroupMet
 
 func (collector *resourcesCollector) tickerCollectorMetrics() {
 	ticker := time.NewTicker(time.Second * time.Duration(collector.collectMetricsWindow))
+	defer ticker.Stop()
 
 	for {
 		select {

bcs-mesos/bcs-hpacontroller/hpacontroller/scaler/bcs-mesos.go

@@ -134,6 +134,7 @@ func (r *bcsMesosScaler) discvMesosdriver() {
 
 	blog.Infof("watch mesosdriver under (%s: %s)", MesosDiscv, discvPath)
 	tick := time.NewTicker(180 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-mesos-driver/mesosdriver/mesosdriver.go

@@ -268,6 +268,7 @@ func (m *MesosDriver) RegDiscover() {
 	blog.Info("DiscoverService(%s) succ", discvPath)
 
 	tick := time.NewTicker(180 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:
@@ -336,6 +337,7 @@ func (m *MesosDriver) DiscvScheduler() {
 	blog.Infof("watch scheduler under (%s: %s), current goroutine num(%d)", MesosDiscv, discvPath, runtime.NumGoroutine())
 
 	tick := time.NewTicker(180 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-mesos-watch/app/watch.go

@@ -266,6 +266,7 @@ func runServer(rdCxt context.Context, cfg *types.CmdConfig, storage storage.Stor
 
 	appRole := "slave"
 	tick := time.NewTicker(60 * time.Second)
+	defer tick.Stop()
 
 	for {
 		select {
@@ -439,6 +440,7 @@ func RefreshDCHost(rfCxt context.Context, cfg *types.CmdConfig, storage storage.
 	blog.Info("DiscoverService(%s) succ", discvPath)
 
 	tick := time.NewTicker(120 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-mesos-watch/cluster/etcd/configmap.go

@@ -72,6 +72,7 @@ func (watch *ConfigMapWatch) Work() {
 
 	watch.ProcessAllConfigmaps()
 	tick := time.NewTicker(12 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/etcd/deployment.go

@@ -76,6 +76,7 @@ func (watch *DeploymentWatch) Work() {
 
 	watch.ProcessAllDeployments()
 	tick := time.NewTicker(10 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/etcd/endpoint.go

@@ -71,6 +71,7 @@ type EndpointWatch struct {
 func (watch *EndpointWatch) Work() {
 	watch.ProcessAllEndpoints()
 	tick := time.NewTicker(10 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/etcd/exportservice.go

@@ -103,6 +103,7 @@ func (watch *ExportServiceWatch) worker(cxt context.Context) {
 	blog.Infof("ExportServiceWatch start work")
 
 	tick := time.NewTicker(120 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-cxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/etcd/secret.go

@@ -72,6 +72,7 @@ func (watch *SecretWatch) Work() {
 
 	watch.ProcessAllSecrets()
 	tick := time.NewTicker(10 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/etcd/service.go

@@ -71,6 +71,7 @@ func (watch *ServiceWatch) Work() {
 
 	watch.ProcessAllServices()
 	tick := time.NewTicker(8 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/app.go

@@ -140,6 +140,7 @@ func (app *AppWatch) pathWatch(cxt context.Context, path string) {
 	app.handleAppList(cxt, path, children)
 
 	tick := time.NewTicker(240 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:
@@ -222,6 +223,7 @@ func (app *AppWatch) appNodeWatch(cxt context.Context, apppath string, ns string
 	blog.V(3).Infof("appwatch wath app ID(%s)", ID)
 
 	tick := time.NewTicker(240 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-mesos-watch/cluster/mesos/configmap.go

@@ -89,6 +89,7 @@ type ConfigMapWatch struct {
 func (watch *ConfigMapWatch) Work() {
 	watch.ProcessAllConfigmaps()
 	tick := time.NewTicker(12 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/deployment.go

@@ -91,6 +91,7 @@ type DeploymentWatch struct {
 func (watch *DeploymentWatch) Work() {
 	watch.ProcessAllDeployments()
 	tick := time.NewTicker(10 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/endpoint.go

@@ -69,6 +69,7 @@ type EndpointWatch struct {
 func (watch *EndpointWatch) Work() {
 	watch.ProcessAllEndpoints()
 	tick := time.NewTicker(10 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/exportservice.go

@@ -98,6 +98,7 @@ func (watch *ExportServiceWatch) postData(data *types.BcsSyncData) {
 
 func (watch *ExportServiceWatch) worker(cxt context.Context) {
 	tick := time.NewTicker(120 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-cxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/mesos.go

@@ -467,6 +467,7 @@ func (ms *MesosCluster) Run(cxt context.Context) {
 
 	//ready to start zk connection monitor
 	tick := time.NewTicker(5 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-cxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/secret.go

@@ -69,6 +69,7 @@ type SecretWatch struct {
 func (watch *SecretWatch) Work() {
 	watch.ProcessAllSecrets()
 	tick := time.NewTicker(10 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/service.go

@@ -68,6 +68,7 @@ type ServiceWatch struct {
 func (watch *ServiceWatch) Work() {
 	watch.ProcessAllServices()
 	tick := time.NewTicker(8 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-watch.cancelCxt.Done():

bcs-mesos/bcs-mesos-watch/cluster/mesos/taskgroup.go

@@ -130,6 +130,7 @@ func (task *TaskGroupWatch) pathWatch(cxt context.Context, path string) {
 
 	//watch children node event
 	tick := time.NewTicker(240 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:
@@ -208,6 +209,7 @@ func (task *TaskGroupWatch) taskGroupNodeWatch(cxt context.Context, taskpath str
 
 	ID := path.Base(taskpath)
 	tick := time.NewTicker(240 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-mesos-watch/storage/cc.go

@@ -299,6 +299,7 @@ func (cc *CCStorage) Run(cxt context.Context) error {
 func (cc *CCStorage) Worker() {
 	blog.Info("CCStorage ready to go into worker!")
 	tick := time.NewTicker(120 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-mesos-watch/storage/channelproxy.go

@@ -32,7 +32,7 @@ type ChannelProxy struct {
 func (proxy *ChannelProxy) Run(cxt context.Context) {
 
 	tick := time.NewTicker(300 * time.Second)
-
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:

bcs-mesos/bcs-scheduler/src/manager/sched/offer/offerpool.go

@@ -609,6 +609,7 @@ func (p *offerPool) setInnerOffersAttributes(offers []*mesos.Offer) {
 
 func (p *offerPool) checkOffers() {
 	tick := time.NewTicker(1 * time.Second)
+	defer tick.Stop()
 
 	for {
 		select {

bcs-mesos/bcs-scheduler/src/manager/sched/scheduler/bcs_event.go

@@ -137,6 +137,7 @@ func (e *bcsEventManager) discvstorage() {
 	blog.Infof("watch storage under (%s: %s), current goroutine num(%d)", e.bcsZk, discvPath, runtime.NumGoroutine())
 
 	tick := time.NewTicker(180 * time.Second)
+	defer tick.Stop()
 	for {
 		select {
 		case <-tick.C:
@@ -187,6 +188,7 @@ func (e *bcsEventManager) discvstorage() {
 func (e *bcsEventManager) handleEventQueue() {
 
 	tick := time.NewTicker(time.Second * 10)
+	defer tick.Stop()
 
 	var err error