Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

通知渠道拓展&自定义方案 #7545

Open
normal-wls opened this issue Aug 28, 2024 · 0 comments · Fixed by #7617
Open

通知渠道拓展&自定义方案 #7545

normal-wls opened this issue Aug 28, 2024 · 0 comments · Fixed by #7617
Labels
stage/for_developing

Comments

@normal-wls
Copy link
Member

背景

用户希望添加微信群机器人通知渠道，在任务执行结束后可以通知到对应的群或者人的企业微信。

考虑到部分通知渠道会因为环境的不同而有所差异，sops 需要同时兼容内外版本环境的通知渠道，所以需要设计成可配置的方案。

目标

除了 cmsi 支持的通知渠道之外，希望支持在不同环境自定义配置新的通知渠道，并在前端渲染支持对应的配置项。

方案设计关注点

  1. 设计自定义通知渠道的配置协议和配置的读取方式，前端如何根据协议进行渲染
  2. 任务结束之后，如何根据保存下来的通知方式进行通知发送（可以考虑策略模式或者适配器模式的设计）
  3. 边界情况：当某个环境修改通知渠道时候，需要如何保持兼容或报错处理
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 12, 2024
@guohelu
feat: 新增通知渠道拓展 TencentBlueKing#7545
eefeb81
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 12, 2024
@guohelu
fix: 修正环境变量获取错误 TencentBlueKing#7545
75e9625
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 12, 2024
@guohelu
fix: 修复逻辑判断错误 TencentBlueKing#7545
2d424bb
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 12, 2024
@guohelu
feat: 新增通知渠道拓展 TencentBlueKing#7545
1185c28
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 12, 2024
@guohelu
fix: 修复逻辑判断错误 TencentBlueKing#7545
1d63db0
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 13, 2024
@guohelu
fix: 修复逻辑错误 TencentBlueKing#7545
7252ff6
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 13, 2024
@guohelu
fix: 修复注释错误 TencentBlueKing#7545
75d3e6d
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 13, 2024
@guohelu
fix: 修复协议问题 TencentBlueKing#7545
2d636fc
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 13, 2024
@guohelu
fix: 修复参数错误 TencentBlueKing#7545
e8bc65b
normal-wls pushed a commit that referenced this issue Nov 13, 2024
@guohelu
feat: 新增通知渠道拓展 #7545 (#7607)
c55800c 
* feat: 新增通知渠道拓展 #7545

* fix: 修复逻辑判断错误 #7545

* fix: 修复逻辑错误 #7545

* fix: 修复注释错误 #7545

* fix: 修复协议问题 #7545

* fix: 修复参数错误 #7545
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 14, 2024
@guohelu
fix: 修复bkchat渠道成功和失败多选bug TencentBlueKing#7545
ffa0b6f
normal-wls pushed a commit that referenced this issue Nov 14, 2024
@guohelu @normal-wls
fix: 修复bkchat渠道成功和失败多选bug #7545
8ee5305
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 18, 2024
@guohelu
fix: 修复联调bug TencentBlueKing#7545
eade30b
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 19, 2024
@guohelu
fix: 修复返回参数和日志打印问题 TencentBlueKing#7545
7d2da04
normal-wls pushed a commit that referenced this issue Nov 19, 2024
@guohelu
fix: 修复联调bug #7545 (#7612)
e46baa2 
* fix: 修复联调bug #7545

* fix: 修复返回参数和日志打印问题 #7545
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 19, 2024
@guohelu
fix: 修复标签问题 TencentBlueKing#7545
6997f91
normal-wls pushed a commit that referenced this issue Nov 19, 2024
@guohelu @normal-wls
fix: 修复标签问题 #7545
0026b40
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 20, 2024
@guohelu
fix: 修复环境变量问题 TencentBlueKing#7545
4d977e9
@guohelu guohelu linked a pull request Nov 20, 2024 that will close this issue
fix: 修复环境变量问题 #7545 #7617
Merged
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 20, 2024
@guohelu
fix: 修正环境变量 TencentBlueKing#7545
ee5dd7d
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 20, 2024
@guohelu
fix: 删除多余导包 TencentBlueKing#7545
19c793e
guohelu added a commit to guohelu/bk-sops that referenced this issue Nov 20, 2024
@guohelu
fix: 修改环境变量读取 TencentBlueKing#7545
e15e043
normal-wls pushed a commit that referenced this issue Nov 20, 2024
@guohelu
fix: 修复环境变量问题 #7545 (#7617)
692b69d 
* fix: 修复环境变量问题 #7545

* fix: 修正环境变量 #7545

* fix: 删除多余导包 #7545

* fix: 修改环境变量读取 #7545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/for_developing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 修复环境变量问题 #7545 guohelu/bk-sops
2 participants
@normal-wls @guohelu