Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI papercuts #50

Closed
bertob opened this issue May 16, 2022 · 5 comments
Closed

UI papercuts #50

bertob opened this issue May 16, 2022 · 5 comments

Comments

@bertob
Copy link

bertob commented May 16, 2022

A few minor UI issues I came across testing the app

  • The icon and text should be centered together on the empty state buttons
  • All button labels should use title case
  • I'd maybe make the "take a shot" label more explicit, "shot" is a bit vague. How about "Take a Screenshot" or "New Scan"?

image

  • The action bar should have a divider line above
  • The buttons in the action bar should not be raised, i.e. have no background unless hovered/active
  • The "take a shot" button should probably have the .suggested-action class

image

  • The "Configure" menu item could be more explicit, e.g. "Manage Languages"
@jannuary
Copy link

jannuary commented Jun 4, 2022

While we're at it, the Language list is quite ugly, and the scrollbar is in the wrong spot:
image
I'd remove the padding from the main box, putting it on the list instead, set selection-mode: none on it, make the download buttons the activatable widgets and used AdwClampScrollable instead of AdwClamp. In addition, .flat isn't really supposed to be used with scrolled views so it intersects the list nastily.

amka added a commit that referenced this issue Jun 6, 2022
amka added a commit that referenced this issue Jun 6, 2022
@amka
Copy link
Contributor

amka commented Jun 6, 2022

@jannuary Your idea is a good one. But I have to mention this window will be totally redesigned in near future. I'll split installed and available languages, and add more options to configure.

@amka
Copy link
Contributor

amka commented Jun 6, 2022

@bertob Thank you! I hope most of the point were fixed in 1.1.0 release.

@bertob
Copy link
Author

bertob commented Jun 6, 2022

Nice, yeah the points from the original issue all look fixed to me!

I agree with @jannuary's suggestions about the language dialog, but maybe that should be a separate issue if it'll be redesigned soon?

@amka
Copy link
Contributor

amka commented Jun 6, 2022

Yep, since you think your issue is done, I'll move this one to its own issue and plan it for the next release.

@bertob bertob closed this as completed Jun 6, 2022
@amka amka mentioned this issue Jun 6, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants