Fix populate networks call (#231)

* Implement proxy auto verification for hardhat-tenderly-v1 * fix populateNetworks call
Tenderly · Sep 26, 2024 · c75285b · c75285b
1 parent 048cd39
commit c75285b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/packages/hre-extender-v1/src/setup.ts b/packages/hre-extender-v1/src/setup.ts
@@ -27,7 +27,8 @@ import { extendUpgrades } from "./extenders/extend-upgrades";
 import { extendHardhatDeploy } from "./extenders/extend-hardhat-deploy";
 import { isTenderlyNetworkConfig } from "./extenders/tenderly-network-resolver";
 import {
-  findEtherscanConfig, populateHardhatVerifyConfig,
+  findEtherscanConfig, 
+  populateHardhatVerifyConfig,
   shouldPopulateHardhatVerifyConfig,
 } from "./extenders/populate-hardhat-verify-config";
 
@@ -169,17 +170,19 @@ const populateNetworks = (): void => {
 
         CHAIN_ID_NETWORK_NAME_MAP[network.ethereum_network_id] = network.slug;
 
-        for (slug of network.metadata.secondary_slugs) {
-          NETWORK_NAME_CHAIN_ID_MAP[slug] = network.ethereum_network_id;
+        if (network?.metadata?.secondary_slugs !== undefined) {
+          for (slug of network.metadata.secondary_slugs) {
+            NETWORK_NAME_CHAIN_ID_MAP[slug] = network.ethereum_network_id;
+          }
         }
       }
       logger.silly(
         "Obtained supported public networks: ",
         NETWORK_NAME_CHAIN_ID_MAP,
       );
     })
-    .catch((_) => {
-      logger.error("Error encountered while fetching public networks");
+    .catch((e) => {
+      logger.error("Error encountered while fetching public networks:", e);
     });
 };
 

diff --git a/packages/hre-extender-v2/src/setup.ts b/packages/hre-extender-v2/src/setup.ts
@@ -171,17 +171,19 @@ const populateNetworks = (): void => {
 
         CHAIN_ID_NETWORK_NAME_MAP[network.ethereum_network_id] = network.slug;
 
-        for (slug of network.metadata.secondary_slugs) {
-          NETWORK_NAME_CHAIN_ID_MAP[slug] = network.ethereum_network_id;
+        if (network?.metadata?.secondary_slugs !== undefined) {
+          for (slug of network.metadata.secondary_slugs) {
+            NETWORK_NAME_CHAIN_ID_MAP[slug] = network.ethereum_network_id;
+          }
         }
       }
       logger.silly(
         "Obtained supported public networks: ",
         NETWORK_NAME_CHAIN_ID_MAP,
       );
     })
-    .catch((_) => {
-      logger.error("Error encountered while fetching public networks");
+    .catch((e) => {
+      logger.error("Error encountered while fetching public networks:", e);
     });
 };