performance(modules): Only import modules that are required. (closes #287) #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleledbetter
approved these changes
Feb 7, 2017
richavyas
reviewed
Feb 7, 2017
| @@ -2,7 +2,7 @@ import { Type } from '@angular/core'; | |||
| import { NgModule, ModuleWithProviders } from '@angular/core'; | |||
|
|
|||
| import { CommonModule } from '@angular/common'; | |||
| import { MaterialModule } from '@angular/material'; | |||
| import { } from '@angular/material'; | |||
There was a problem hiding this comment.
What's the intent behind leaving this empty?
There was a problem hiding this comment.
To see if people would notice haha jk, my bad
richavyas
reviewed
Feb 7, 2017
| @@ -2,7 +2,7 @@ | |||
| <md-select [(ngModel)]="value" | |||
| [placeholder]="label" | |||
| [required]="required" | |||
| flex> | |||
| flex="100"> | |||
There was a problem hiding this comment.
Probably I am not aware, how flex is different from flex="100"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is an issue
tree shakingbecause of how Typescript + Webpack compile and bundle things.angular/angular-cli#2901
webpack/webpack#2899
We do not want to depend on tree shaking alone (if they fix it great, if not doesnt matter), so we need to explicitly import the modules that are required and nothing else. #287
For now we will just assume that if you import
CovalentCoreModuleyou want everything, but if you import asubmodulethen we will only use the required ones.What's included?
MaterialModule.forRoot()imports and only adding required ones permodulee.g.
Search module only requires the following modules:
Test Steps
ng serveGeneral Tests for Every PR
ng serve --aotstill works.npm run lintpasses.npm testpasses and code coverage is not lower.npm run buildstill works.