Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): use MdAutocomplete, MdChipList and MdBasicChip + bugfixes + a11y. (closes #215) (closes #165) (closes #96) #459

Merged
merged 20 commits into from
Apr 2, 2017

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Mar 28, 2017

Description

#215
#165
#96

Since now we are using MdAutocomplete under the covers, TdChips will follow the material spec better and wont have the cross-browser issues that datalist had.

What's included?

  • feat(chips): remove TdAutocompleteComponent and use MdAutocomplete
  • feat(chips): remove TdChipComponent and leverage md-chip-list and md-basic-chip
  • feat(chips): filter items depending on input value for autocomplete
  • enhancement(chips): change input label when incorrect + remove warn when value changes
  • feat(chips): add better a11y to td-chips

Test Steps

General Tests for Every PR

  • ng serve --aot still works.
  • npm run lint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to CodePen/Plunker/JSfiddle

td-chips-v2

@emoralesb05 emoralesb05 added this to the Beta 3 milestone Mar 28, 2017
@kyleledbetter
Copy link
Contributor

Twould be a lovely a11y feature to enable backspace to remove a chip and <- and -> arrow chip selection like ng1:

chips-a11y

(also esc goes back to the input no matter which chip is selected)

@emoralesb05 emoralesb05 changed the title feat(chips): use MdAutocomplete, MdChipList and MdBasicChip + bugfixes. (closes #215) (closes #165) (closes #96) feat(chips): use MdAutocomplete, MdChipList and MdBasicChip + bugfixes + a11y. (closes #215) (closes #165) (closes #96) Mar 31, 2017
@kyleledbetter kyleledbetter merged commit 170174a into develop Apr 2, 2017
@kyleledbetter kyleledbetter deleted the feature/autocomplete-chips branch April 2, 2017 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants