Generate names for cities #39

mayant15 · 2019-03-30T17:18:19Z

Solves #22 by generating city names.

To test:

Find a city and go near its centre
There'll be a blue name tag showing the city's name
Specify a theme in your culture prefab to customise the generated name

Names are now assigned to sites on world generation as opposed to on encounter.

Cervator

Looks fine to me, although I haven't tested yet pending WIP :-)

Would be nice with some quick instructions of what to look for / how to test when ready.

Cervator · 2019-03-30T17:26:24Z

src/main/java/org/terasology/dynamicCities/settlements/SettlementEntityManager.java

    @Override
    public void postBegin() {

        settlementEntities = settlementCachingSystem.getSettlementCacheEntity();
-        rng = new FastRandom(regionEntityManager.hashCode() & 0x921233);
+        long seed = regionEntityManager.hashCode() & 0x921233;


Would it be worth trying to hook into the world seed instead? Also might help to make a variable/constant for the magic string here to explain its meaning (it seems fairly obvious but is a good practice)

I think leaving this one as is is fine.
The names are hooked into the world seed below, this is for the other randoms, like city generation over time. If you hooked it into the seed it wouldn't really matter because all the other factors would be different

src/main/java/org/terasology/dynamicCities/settlements/SettlementEntityManager.java

src/main/java/org/terasology/dynamicCities/population/CultureComponent.java

src/main/java/org/terasology/dynamicCities/settlements/SettlementEntityManager.java

mayant15 · 2019-04-01T19:06:48Z

Updated. Had some questions so I left them as comments :)

skaldarnar

Overall looks good to me. Will test it in game now =)

skaldarnar · 2019-04-12T19:46:18Z

src/main/java/org/terasology/dynamicCities/population/ThemeManager.java

+
+@Share(ThemeManager.class)
+@RegisterSystem(RegisterMode.AUTHORITY)
+public class ThemeManager extends BaseComponentSystem {


I'd like to see a short class comment here explaining what this manager is about, and what a theme is supposed to be. Not critical for mergin though...

skaldarnar · 2019-04-12T19:47:15Z

src/main/java/org/terasology/dynamicCities/population/ThemeManager.java

+    @In
+    AssetManager assetManager;
+
+    private Set<TownNameComponent> themeComponents = new HashSet<>();


Why are themeComponents actually TownNameComponents? Just out of convenience as the town name happens to contain information about the theme as well?

skaldarnar · 2019-04-12T19:47:53Z

src/main/java/org/terasology/dynamicCities/population/ThemeManager.java

+
+    @Override
+    public void postBegin() {
+        logger.info("Loading default themes...");


I wonder whether we should reduce the log levels here... should those info logs actually be debug instead?

skaldarnar · 2019-04-12T19:58:31Z

src/main/java/org/terasology/dynamicCities/population/ThemeManager.java

+            }
+        }
+        themeNames += "]";
+        logger.info("Finished loading themes: " + themeComponents.size() + " theme types found: " + themeNames);


The code above is just used for generating the log message, isn't it? I think we should remove it.

The following code using Stream API should yieldthe same result as your iterator-based code. The code is more declarative though which often helps to think more about the what than the how 😉

themeComponents .stream() .map(c -> c.name) .collect(Collectors.joining(", ", "[", "]") .toString()

skaldarnar · 2019-04-12T19:59:30Z

src/main/java/org/terasology/dynamicCities/population/TownNameComponent.java

+    public String name;
+    public List<String> prefixes;
+    public List<String> postfixes;
+    public List<String> nameList;


What is nameList supposed to be, given there are already name and prefixes and postfixes ? Is it some kind of tag list?

skaldarnar · 2019-04-12T20:51:41Z

src/main/java/org/terasology/dynamicCities/population/ThemeManager.java

+import org.terasology.entitySystem.systems.BaseComponentSystem;
+import org.terasology.entitySystem.systems.RegisterMode;
+import org.terasology.entitySystem.systems.RegisterSystem;
+import org.terasology.namegenerator.town.DebugTownTheme;


One thing: is the namegenerator a transitive dependency? Do we need to add it to the module dependencies?

skaldarnar · 2019-04-12T20:59:31Z

Game crashed right when I discovered the first city....
https://pastebin.com/aju33JPY

Edit: I did not have any culture activated... with MedievalCities in the active modules I can see that the city has a name when looking in the console, but there is no name tag showing in the world

I would like to avoid a hard crash like the one that happens when you don't active an additional culture module, but the hardening against these case could also happen in another PR...

Edit 2: Finally got a working version with name tags showing... @Cervator what's the difference between using MedievalCities game mode and just activating the modules on their own? The first works as intended, the second does not show name tags for me...

Cervator · 2019-04-28T19:32:33Z

Bump - @mayant15 you still out there? :-)

The SiteFacetProvider no longer looks for sufficient grass when deciding if a site is suitable for building a city.

- Created basic container classes - Created temporary mock functions - Setup SettlementEntityManager to create roads as it creates buildings

- Buildings of the source will not be built upon roads - RoadSegments will be laid down better

Names are now assigned to sites on world generation as opposed to on encounter.

mayant15 · 2019-07-07T03:54:12Z

Closing this one, consider #46 instead.

mayant15 added 3 commits March 30, 2019 21:45

Add random names to cities

04b7c10

Add names at world generation

be98fad

Names are now assigned to sites on world generation as opposed to on encounter.

Clean up and format code

f858702

Cervator approved these changes Mar 30, 2019

View reviewed changes

mayant15 added 2 commits April 1, 2019 13:03

Split up Settlement and Site components

bfe433e

Allow town theme to be specified in the culture component

06dfc74

mayant15 commented Apr 1, 2019

View reviewed changes

src/main/java/org/terasology/dynamicCities/population/CultureComponent.java Outdated Show resolved Hide resolved

mayant15 commented Apr 1, 2019

View reviewed changes

src/main/java/org/terasology/dynamicCities/settlements/SettlementEntityManager.java Outdated Show resolved Hide resolved

skaldarnar self-requested a review April 2, 2019 08:09

mayant15 added 4 commits April 2, 2019 18:09

Add custom themes

289be32

Code style fixes

c60aef5

Restructure SettlementComponent

186bedd

Add default constructor to SettlementComponent

dec65d3

mayant15 changed the title ~~[WIP] Generate names for cities~~ Generate names for cities Apr 12, 2019

skaldarnar approved these changes Apr 12, 2019

View reviewed changes

skaldarnar reviewed Apr 12, 2019

View reviewed changes

skaldarnar mentioned this pull request Apr 13, 2019

StructureTemplate placement still off at times #35

Closed

mayant15 and others added 10 commits May 1, 2019 22:21

Refactor code

f4872fd

Add NameGenerator to module dependencies

b38828f

Remove sufficient grass condition

9c637a9

The SiteFacetProvider no longer looks for sufficient grass when deciding if a site is suitable for building a city.

Add city centre icon to minimap

f416e1b

Fix icon scaling with zoom

3a3928b

Add network constraints to CentreOverlay addition

2c2cde1

Make icon persist when city moves out of view

caa11d5

Add javadocs

cdd9c43

Add location component to building entities

0998206

Setup road construction pipeline

ba15ee7

- Created basic container classes - Created temporary mock functions - Setup SettlementEntityManager to create roads as it creates buildings

mayant15 added 12 commits July 7, 2019 08:55

Calculate and place RoadParcels between settlements

483e818

Add a rasterizer to place blocks

ea8b9c8

Better place and clear out space for roads

a789180

- Buildings of the source will not be built upon roads - RoadSegments will be laid down better

Add gravel blocks to road

db319e2

Add road rasterizer and theme to construction system

0c0fc25

Create roads from the nearest city only

c76ed0e

Clean up code

d49fe91

Refactor and add javadocs

0308f9d

Add random names to cities

8b70162

Add names at world generation

4eadbbd

Names are now assigned to sites on world generation as opposed to on encounter.

Clean up and format code

5d33fcd

Split up Settlement and Site components

a288c6d

mayant15 mentioned this pull request Jul 7, 2019

Updated city names #46

Merged

mayant15 closed this Jul 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate names for cities #39

Generate names for cities #39

mayant15 commented Mar 30, 2019 •

edited

Loading

Cervator left a comment

Cervator Mar 30, 2019

syntaxi Mar 31, 2019

mayant15 commented Apr 1, 2019

skaldarnar left a comment

skaldarnar Apr 12, 2019

skaldarnar Apr 12, 2019

skaldarnar Apr 12, 2019

skaldarnar Apr 12, 2019

skaldarnar Apr 12, 2019

skaldarnar Apr 12, 2019

skaldarnar commented Apr 12, 2019 •

edited

Loading

Cervator commented Apr 28, 2019

mayant15 commented Jul 7, 2019

Generate names for cities #39

Generate names for cities #39

Conversation

mayant15 commented Mar 30, 2019 • edited Loading

Cervator left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mayant15 commented Apr 1, 2019

skaldarnar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

skaldarnar commented Apr 12, 2019 • edited Loading

Cervator commented Apr 28, 2019

mayant15 commented Jul 7, 2019

mayant15 commented Mar 30, 2019 •

edited

Loading

skaldarnar commented Apr 12, 2019 •

edited

Loading