Implementing names for characters #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request works exactly as stated, names are generated for each character and displayed on the tooltip, very well done! Some ideas that I have for some of the logistic questions you proposed:
|
mayant15
requested changes
Mar 30, 2020
skaldarnar
requested changes
Apr 7, 2020
| import org.terasology.registry.In; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.Random; | ||
|
|
||
| import static org.terasology.namegenerator.creature.CreatureAssetTheme.COUNTRY; |
There was a problem hiding this comment.
As I've requested to change the name list prefix to "Old West" this (and probably other spots) need changes now... 🙄 I'm eager to merge Terasology/NameGenerator#23, though (after renames) 👍
Suggested change
| import static org.terasology.namegenerator.creature.CreatureAssetTheme.COUNTRY; | |
| import static org.terasology.namegenerator.creature.CreatureAssetTheme.OLD_WEST; |
| @@ -124,6 +134,12 @@ private EntityRef spawnCitizen(EntityRef homeEntity) { | |||
|
|
|||
| EntityRef entityRef = entityBuilder.build(); | |||
|
|
|||
| if(entityRef.hasComponent(DisplayNameComponent.class)) { | |||
| DisplayNameComponent displayNameComponent = entityRef.getComponent(DisplayNameComponent.class); | |||
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.COUNTRY); | |||
There was a problem hiding this comment.
Suggested change
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.COUNTRY); | |
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.OLD_WEST); |
| SettlementRefComponent settlementRefComponent = entityRef.getComponent(SettlementRefComponent.class); | ||
| trader.addComponent(settlementRefComponent); | ||
| MarketComponent marketComponent = settlementRefComponent.settlement.getComponent(MarketComponent.class); | ||
| if(entityRef.hasComponent(DisplayNameComponent.class)) { | ||
| DisplayNameComponent displayNameComponent = entityRef.getComponent(DisplayNameComponent.class); | ||
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.COUNTRY); |
There was a problem hiding this comment.
Suggested change
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.COUNTRY); | |
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.OLD_WEST); |
skaldarnar
reviewed
Apr 16, 2020
| if(entityRef.hasComponent(DisplayNameComponent.class)) { | ||
| DisplayNameComponent displayNameComponent = entityRef.getComponent(DisplayNameComponent.class); | ||
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), OLD_WEST); | ||
| displayNameComponent.name = creatureNameProvider.generateName(); |
There was a problem hiding this comment.
Do you also need to save the component again?
There was a problem hiding this comment.
Yea, will add that. However, I feel like it doesn't really make a difference here.
| if(entityRef.hasComponent(DisplayNameComponent.class)) { | ||
| DisplayNameComponent displayNameComponent = entityRef.getComponent(DisplayNameComponent.class); | ||
| CreatureNameProvider creatureNameProvider = new CreatureNameProvider(random.nextLong(), CreatureAssetTheme.OLD_WEST); | ||
| displayNameComponent.name = "shopkeeper " + creatureNameProvider.generateName(); |
There was a problem hiding this comment.
Same here - save the component after modifying it?
|
Closed, this feature is implemented as part of #74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of names on characters.
There are still a bunch of logistic questions to be answered like whether we want to display the type of citizens too in the Tooltips. Would love to hear the community's opinions on this
Further, the names are being taken from a list of ELVEN names prefab in Name Generator. We could definitely add a prefab with Citizen names. Also the shopkeeper's name is rendered as a shopkeeper itself (again something I'd like to hear your opinions on).
And as always, a review is much appreciated :).
Added Terasology/NameGenerator#23 to Hopefully use Country names instead of ELVEN names, However sometimes, Names that do not belong to the list pop up in the citizen Tooltips.
Might need some testing and bug finding.