Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is just a draft of some updates for i18next configuration, but it would be nice to discuss them.
This introduces
config
file (if not defined default values used). This should replace the instance ofi18n.js
file (used inprerequisites
).i18next-xhr-backend
so language files get pulled from the backend (this will require exposingLanguages
so a browser can access them). More info about it here.eslint-plugin-i18next
. This should wait for changes from this pull request. This would be useful to detect hard-coded strings. Needs a lot of work to separate all strings that should not be detected as hard-coded (currently detects over 1k of problems). Currently works only on.js
and.jsx
files, to make it work for.ts
files Model architecture: Enable eslint for .ts files #3303 is needed.Checklist