-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoJson vector-tile dynamic styling #5900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 26, 2021
tephenavies
approved these changes
Nov 16, 2021
This was referenced Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
GeoJsonMixin.style["stroke-opacity"]
will now also setpolygonStroke.alpha
andpolylineStroke.alpha
(Specifying stroke-opacity for geojson polygons in init files does not work #5870)GeoJsonMixin
default stroke width from2
to1
TableMixin
styling toGeoJsonMixin
- it will treat geojson feature properties as "rows" in a table - which can be styled in the same way asTableMixin
(eg CSV). This is only enabled for geojson-vt/Protomaps (which requiresTerria.configParameters.enableGeojsonVt = true
). For more info seeGeojsonMixin.forceLoadMapItems()
GeojsonTraits.disableTableStyle
@types/geojson
Geojson types with@turf/helpers
GeojsonMixin
replaced withcustomDataLoader
,loadFromFile
andloadFromUrl
withforceLoadGeojsonData
GeojsonMixin
will now convert all geojson objects to FeatureCollectionGeojsonMixin
will now add proper file extensionsWebFeatureServiceCatalogItem
andSocrataMapViewCatalogItem
now usesGeoJsonMixin
All Catalog items should use GeojsonMixin instead of creating GeoJsonCatalogItems #5380ProtomapsImageryProvider
geojson feature picking over antimeridianGeojsonStyleTraits
(Note these are not apart of simplestyle-spec and can only be used withgeojson-vt
)Test links
Warning some of the datasets are quite large, so may take a while to load
Pacificmap
http://ci.terria.io/vector-styling/#configUrl=https://raw.githubusercontent.com/TerriaJS/saas-catalogs-public/main/pacificmap/map-config/prod.json&share=s-zwoZq0MAbEny41Vmg6vrCEnUKlg
Nationalmap
http://ci.terria.io/vector-styling/#configUrl=https://nationalmap.gov.au/config.json&share=s-kLItCqL3Fe4aSVfBFAnCnpwoXqJ
Checklist
doc/
.