Improve ShouldRedirectTo<TController> exception message

[AlexArchive]

When the consumer calls ShouldRedirectTo<TController> where TController is of the same type as the controller under test like this:

var sut = new HomeController();
sut.WithCallTo(c => c.Index())
    .ShouldRedirectTo<HomeController>(c => c.Index());

The assertion fails with the following error:

Expected redirect to action 'Index' in 'Home' controller, but instead was given redirect to action 'Index' within the same controller.

I encountered this error message when I mistakenly supplied the generic type argument. I knew to remove it because I have some experience with this library.

Maybe I am dumb or maybe this is a common mistake. Might it be helpful to change the exception message to something like this:

Expected redirect to action 'Index' in 'Home' controller, but instead was given redirect to action 'Index' within the same controller. If this was the intended assertion then please remove the generic type argument.

[robdmoore]

Or we can make that scenario work. I don't see why that shouldn't pass...

On 26 Nov 2014, at 4:40 am, ByteBlast notifications@github.com wrote:

When the consumer calls ShouldRedirectTo where TController is of the same type as the controller under test like this:

var sut = new HomeController();
sut.WithCallTo(c => c.Index())
.ShouldRedirectTo(c => c.Index());
The assertion fails with the following error:

Expected redirect to action 'Index' in 'Home' controller, but instead was given redirect to action 'Index' within the same controller.

I encountered this error message when I mistakenly supplied the generic type argument. I knew to remove it because I have some experience with this library.

Maybe I am dumb or maybe this is a common mistake. Might it be helpful to change the exception message to something like this:

Expected redirect to action 'Index' in 'Home' controller, but instead was given redirect to action 'Index' within the same controller. If this was the intended assertion then please remove the generic type argument.

—
Reply to this email directly or view it on GitHub.

[AlexArchive]

I wasn't too sure why it didn't pass either.

I assumed that you did it on purpose?

[robdmoore]

No. It's an oversight ;)

On 26 Nov 2014, at 6:19 am, ByteBlast notifications@github.com wrote:

I wasn't too sure why it didn't pass either. I assumed that you did it on purpose?

—
Reply to this email directly or view it on GitHub.

[AlexArchive]

Yeah of course. I will remove the if that throws and see if all the tests pass (soon).

[AlexArchive]

Thank you for your input in all cases.