Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added dedicated _AngleTween to improve rotation animation #28

Merged
merged 4 commits into from
Mar 22, 2024
Merged

fix: added dedicated _AngleTween to improve rotation animation #28

merged 4 commits into from
Mar 22, 2024

Conversation

JaffaKetchup
Copy link
Contributor

Current animated rotation behaviour:

2024-03-21.22-08-47.mp4

New animated rotation behaviour:

2024-03-21.22-09-50.mp4

I haven't fully tested these changes. They just introduce a dedicated tween to better animate between the shortest angle diff.

Copy link
Owner

@TesteurManiak TesteurManiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM, I just might not be sure why _AngleTween needs to be private 🤔

@TesteurManiak TesteurManiak added the enhancement New feature or request label Mar 22, 2024
@JaffaKetchup
Copy link
Contributor Author

It can be public!

@TesteurManiak TesteurManiak merged commit 0da6976 into TesteurManiak:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants