Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customId for for animated movements and don't trigger movement when it isn't necessary #5

Merged
merged 2 commits into from
May 31, 2023

Commits on May 30, 2023

  1. Add customId for for animated movements and don't trigger movement wh…

    …en it isn't necessary
    
    Adding an optional customId allows users to change the TileLayer's
    tileUpdateTransformer behaviour based on what triggers an animated
    movement.
    
    In passing I noticed that it was possible to optimise the movement such
    that no calls to the MapController are made if no movement occurs and if
    both movement/rotation occur the MapControllers moveAndRotate method is
    used which is more efficient than calling both move() and rotate().
    
    I also added a check to make sure that if we animate movement that we
    don't repeat the last movement (when animation.value == 1.0) and that we
    use the AnimatedMoveId.finish id exactly once.
    rorystephenson committed May 30, 2023
    Configuration menu
    Copy the full SHA
    de9359a View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. Address PR feedback

    rorystephenson committed May 31, 2023
    Configuration menu
    Copy the full SHA
    8731a91 View commit details
    Browse the repository at this point in the history