Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for persistent connection in client #137

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Fix for persistent connection in client #137

merged 1 commit into from
Apr 18, 2021

Conversation

sirn-se
Copy link
Contributor

@sirn-se sirn-se commented Apr 17, 2021

Variable $address is used outside the if-block, so moving the setting if it outside as well.

@sirn-se sirn-se added the bug label Apr 17, 2021
@sirn-se sirn-se linked an issue Apr 17, 2021 that may be closed by this pull request
Undefined variable: address #136
Closed
@sirn-se sirn-se mentioned this pull request Apr 17, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 06e40b7 on persistent-fix into caa1610 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 06e40b7 on persistent-fix into caa1610 on master.

@sirn-se sirn-se merged commit 25f6e32 into master Apr 18, 2021
@sirn-se sirn-se deleted the persistent-fix branch April 27, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined variable: address
2 participants
@sirn-se @coveralls