Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSelect property removed v2.x #237

Closed
mfklauberg opened this issue Feb 22, 2023 · 3 comments · Fixed by #238
Closed

onSelect property removed v2.x #237

mfklauberg opened this issue Feb 22, 2023 · 3 comments · Fixed by #238

Comments

@mfklauberg
Copy link
Contributor

Hello,

Comparing the exposed component properties between v1 and v2, I noticed that the onSelect property was removed, but couldn't find any reference for this breaking change within the release notes changelog.

Was its removal intentional, and if not, would it be possible for it to be added back? If thats the case, I would be open to make the change and open a PR for it.

Thanks in advance.

@forrestbao
Copy link
Member

Hi @mfklauberg, please go ahead to add it back and open a PR. Thank you very much for your contribution.

@mfklauberg
Copy link
Contributor Author

Thanks, will start working on it asap

@mfklauberg
Copy link
Contributor Author

Hi @forrestbao, opened #238 adding the feature back, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants