-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support onSelect
callback
#238
Conversation
✅ Deploy Preview for any-viewer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I'm thinking about moving this logic to |
Before opening the issue and the PR, one of my options was to implement a custom values render to put a click event in the DOM, so I think that this is already possible today, just the event registered in the main component won't be the same and would need to be used in all custom rendered values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 87.41% // Head: 87.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 87.41% 87.51% +0.10%
==========================================
Files 18 18
Lines 1971 1987 +16
Branches 350 352 +2
==========================================
+ Hits 1723 1739 +16
Misses 248 248
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Adding back the
onSelect
property.closes #237