Skip to content

Commit

Permalink
Merge pull request #3514 from mdmintz/complete-the-3.7-drop
Browse files Browse the repository at this point in the history
Drop Python 3.7 leftovers
  • Loading branch information
willmcgugan authored Oct 4, 2024
2 parents 6607492 + 0a549ce commit 8b84ee9
Show file tree
Hide file tree
Showing 7 changed files with 3 additions and 27 deletions.
2 changes: 1 addition & 1 deletion .readthedocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ sphinx:
formats: all

python:
version: 3.7
version: 3.8
install:
- requirements: docs/requirements.txt
- method: pip
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ See what [people are saying about Rich](https://www.willmcgugan.com/blog/pages/p

## Compatibility

Rich works with Linux, macOS and Windows. True color / emoji works with new Windows Terminal, classic terminal is limited to 16 colors. Rich requires Python 3.7 or later.
Rich works with Linux, macOS and Windows. True color / emoji works with new Windows Terminal, classic terminal is limited to 16 colors. Rich requires Python 3.8 or later.

Rich works with [Jupyter notebooks](https://jupyter.org/) with no additional configuration required.

Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ classifiers = [
"Operating System :: Microsoft :: Windows",
"Operating System :: MacOS",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand Down Expand Up @@ -45,7 +44,6 @@ pytest-cov = "^3.0.0"
attrs = "^21.4.0"
pre-commit = "^2.17.0"
asv = "^0.5.1"
importlib-metadata = { version = "*", python = "<3.8" }

[build-system]
requires = ["poetry-core>=1.0.0"]
Expand Down
10 changes: 0 additions & 10 deletions tests/test_inspect.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,6 @@
)
from rich.console import Console

skip_py37 = pytest.mark.skipif(
sys.version_info.minor == 7 and sys.version_info.major == 3,
reason="rendered differently on py3.7",
)

skip_py38 = pytest.mark.skipif(
sys.version_info.minor == 8 and sys.version_info.major == 3,
reason="rendered differently on py3.8",
Expand Down Expand Up @@ -122,7 +117,6 @@ def test_inspect_text():
assert render("Hello") == expected


@skip_py37
@skip_pypy3
def test_inspect_empty_dict():
expected = (
Expand Down Expand Up @@ -221,7 +215,6 @@ def test_inspect_integer_with_value():
assert value == expected


@skip_py37
@skip_py310
@skip_py311
@skip_py312
Expand Down Expand Up @@ -259,7 +252,6 @@ def test_inspect_integer_with_methods_python38_and_python39():
assert render(1, methods=True) == expected


@skip_py37
@skip_py38
@skip_py39
@skip_py311
Expand Down Expand Up @@ -302,7 +294,6 @@ def test_inspect_integer_with_methods_python310only():
assert render(1, methods=True) == expected


@skip_py37
@skip_py38
@skip_py39
@skip_py310
Expand Down Expand Up @@ -347,7 +338,6 @@ def test_inspect_integer_with_methods_python311():
assert render(1, methods=True) == expected


@skip_py37
@skip_pypy3
def test_broken_call_attr():
class NotCallable:
Expand Down
5 changes: 0 additions & 5 deletions tests/test_pretty.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
from rich.pretty import Node, Pretty, _ipy_display_hook, install, pprint, pretty_repr
from rich.text import Text

skip_py37 = pytest.mark.skipif(
sys.version_info.minor == 7 and sys.version_info.major == 3,
reason="rendered differently on py3.7",
)
skip_py38 = pytest.mark.skipif(
sys.version_info.minor == 8 and sys.version_info.major == 3,
reason="rendered differently on py3.8",
Expand Down Expand Up @@ -656,7 +652,6 @@ class Foo:
assert result == expected


@skip_py37
@skip_py38
@skip_py39
def test_attrs_broken_310() -> None:
Expand Down
7 changes: 0 additions & 7 deletions tests/test_repr.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import sys
from typing import Optional

import pytest
Expand All @@ -8,11 +7,6 @@

from inspect import Parameter

skip_py37 = pytest.mark.skipif(
sys.version_info.minor == 7 and sys.version_info.major == 3,
reason="rendered differently on py3.7",
)


@rich.repr.auto
class Foo:
Expand Down Expand Up @@ -100,7 +94,6 @@ def test_rich_repr() -> None:
assert (repr(Foo("hello", bar=3))) == "Foo('hello', 'hello', bar=3, egg=1)"


@skip_py37
def test_rich_repr_positional_only() -> None:
_locals = locals().copy()
exec(
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ minversion = 4.0.0
envlist =
lint
docs
py{37,38,39,310,311,312,313}
py{38,39,310,311,312,313}
isolated_build = True

[testenv]
Expand Down

0 comments on commit 8b84ee9

Please sign in to comment.