Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix pretty_repr for deque #2864

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Mar 7, 2023

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

Fixes #2863

Add new function _get_braces_for_deque to respect maxlen for collections.deque.
Add tests for pretty_repr with non-empty and empty deque.

@XuehaiPan XuehaiPan changed the title fix: fix get braces for deque fix: fix pretty_repr for deque Mar 7, 2023
@willmcgugan willmcgugan disabled auto-merge July 1, 2024 10:52
@willmcgugan willmcgugan merged commit 9e3933f into Textualize:master Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rich.pretty is not showing maxlen for collections.deque
2 participants